Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap arguments to tokenize #149

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Swap arguments to tokenize #149

merged 1 commit into from
Sep 11, 2017

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Sep 8, 2017

For consistency with compile(), let’s have language be the first argument instead of the last. It reads better this way anyhow: since tokens is often an inline object literal, it’s easy to forget to specify the language afterwards.

/ref #146 (comment)
/cc @mcwhittemore

@1ec5 1ec5 self-assigned this Sep 8, 2017
@1ec5 1ec5 mentioned this pull request Sep 8, 2017
Merged
@1ec5 1ec5 changed the title Swapped arguments to tokenize Swap arguments to tokenize Sep 8, 2017
mcwhittemore
mcwhittemore approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@mcwhittemore mcwhittemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I've already forgotten this a few times. So good idea.

@1ec5 1ec5 merged commit 4cdec98 into master Sep 11, 2017
@1ec5 1ec5 deleted the 1ec5-tokenize-language-first branch September 11, 2017 17:55
This was referenced Sep 11, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcwhittemore mcwhittemore mcwhittemore approved these changes

Assignees

@1ec5 1ec5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @mcwhittemore