Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate＋Rename #863

Closed
wants to merge 29 commits into from
Closed

Seperate＋Rename #863

wants to merge 29 commits into from

Conversation

konbraphat51
Copy link
Contributor

No description provided.

konbraphat51 and others added 29 commits November 9, 2023 23:55
@konbraphat51
Merge pull request #3 from PyThaiNLP/dev
e39b622 
update
@konbraphat51
documentation
6ea4181
@konbraphat51
Add: implemation
be29c00 
tested
@konbraphat51
Add: test code
3e94234
@konbraphat51
Add: remove_repeat_consonants()
ca6cd94 
function to remove consonants
เริ่ดดดดดดดด -> เริ่ด

implementation + test code written.
Test passed
@konbraphat51
Merge branch 'dev' of https://github.com/konbraphat51/pythainlp into dev
181664c
@konbraphat51
Fix: push miss
702be9a 
this is the right commit
@konbraphat51
Fix: divide the exceeding length code
130b1ec
@konbraphat51
Refac: remove last white space
ef8ac0f
@konbraphat51
Fix: restrict only to consonants
2df4d37
@konbraphat51
Refac: Remove unused import
16c3154
@konbraphat51
Refac: Use enumerate
cc62a95 
pointed out by codacy
@konbraphat51
Fix: add the function in init
d74af32
@konbraphat51
Refac: use black
5bfa50d
@konbraphat51
Refac: repeatedly used black
28b6006 
"1 file left unchanged." shown
@konbraphat51
Refac: resolve nested if
c6b564d 
pointed out by codeclimate
@konbraphat51
Fix test case
8d09323
@konbraphat51
Refac: seperate function
946f59c 
Cognitive complexity pointed out by CodeClimate

Black used
@konbraphat51
Refac: reduce line length
a5153e0 
pointed out by Lint
black used
@konbraphat51
Refac: seperate 2 functions
43dfd25
@konbraphat51
Refac: use black
d9ae534 
vscode autopep8 and black has been conflicting. So autopep8 cutted
@konbraphat51
Refac: seperate match finding method
844c21d 
cognitive complexity pointed out by CodeClimate.
Black used.
@konbraphat51
Improve: save consonants repeaters for improve speed
1e1631f 
TODO resolved, black used, test passed
@konbraphat51
Refac: make repeater checking function
ceb9d76 
Code complexity pointed out by CodeClimate, black used
@konbraphat51
Refac: seperate function
6509e0d
@konbraphat51
Improve: Rename method
9c1a34c 
suggested by PyThaiNLP#862 (comment)
@konbraphat51
Refac: make names more clear
24c3050
@konbraphat51
Refac: reflect method name change
13cf54a
@konbraphat51
Fix: argument inconsistence
a94fccb
@pep8speaks
Copy link

Hello @konbraphat51! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 51:69: W291 trailing whitespace
Line 124:9: W503 line break before binary operator
Line 126:9: W503 line break before binary operator
Line 245:13: W503 line break before binary operator
Line 245:50: E203 whitespace before ':'
Line 247:13: W503 line break before binary operator

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konbraphat51
Copy link
Contributor Author

Sorry mistake PR

@coveralls
Copy link

coveralls commented Nov 11, 2023 •
edited
Loading

Coverage Status

coverage: 86.993% (+87.0%) from 0.0%
when pulling a94fccb on konbraphat51:f_rrc
into edb52b3 on PyThaiNLP:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konbraphat51 @pep8speaks @coveralls