Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate＋Rename #863

Closed
wants to merge 29 commits into from
Closed

Seperate＋Rename #863

wants to merge 29 commits into from

Commits on Nov 9, 2023

  1. Merge pull request #3 from PyThaiNLP/dev 

    update
    @konbraphat51
    konbraphat51 authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e39b622 View commit details
    Browse the repository at this point in the history

  2. documentation

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    6ea4181 View commit details
    Browse the repository at this point in the history

  3. Add: implemation 

    tested
    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    be29c00 View commit details
    Browse the repository at this point in the history

  4. Add: test code

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3e94234 View commit details
    Browse the repository at this point in the history

  5. Add: remove_repeat_consonants() 

    function to remove consonants
เริ่ดดดดดดดด -> เริ่ด

implementation + test code written.
Test passed
    @konbraphat51
    konbraphat51 authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ca6cd94 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' of https://github.com/konbraphat51/pythainlp into dev

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    181664c View commit details
    Browse the repository at this point in the history

  7. Fix: push miss 

    this is the right commit
    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    702be9a View commit details
    Browse the repository at this point in the history

  8. Fix: divide the exceeding length code

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    130b1ec View commit details
    Browse the repository at this point in the history

  9. Refac: remove last white space

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ef8ac0f View commit details
    Browse the repository at this point in the history

  10. Fix: restrict only to consonants

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2df4d37 View commit details
    Browse the repository at this point in the history

  11. Refac: Remove unused import

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    16c3154 View commit details
    Browse the repository at this point in the history

  12. Refac: Use enumerate 

    pointed out by codacy
    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    cc62a95 View commit details
    Browse the repository at this point in the history

  13. Fix: add the function in init

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d74af32 View commit details
    Browse the repository at this point in the history

  14. Refac: use black

    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5bfa50d View commit details
    Browse the repository at this point in the history

  15. Refac: repeatedly used black 

    "1 file left unchanged." shown
    @konbraphat51
    konbraphat51 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    28b6006 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Refac: resolve nested if 

    pointed out by codeclimate
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c6b564d View commit details
    Browse the repository at this point in the history

  2. Fix test case

    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    8d09323 View commit details
    Browse the repository at this point in the history

  3. Refac: seperate function 

    Cognitive complexity pointed out by CodeClimate

Black used
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    946f59c View commit details
    Browse the repository at this point in the history

  4. Refac: reduce line length 

    pointed out by Lint
black used
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a5153e0 View commit details
    Browse the repository at this point in the history

  5. Refac: seperate 2 functions

    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    43dfd25 View commit details
    Browse the repository at this point in the history

  6. Refac: use black 

    vscode autopep8 and black has been conflicting. So autopep8 cutted
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d9ae534 View commit details
    Browse the repository at this point in the history

  7. Refac: seperate match finding method 

    cognitive complexity pointed out by CodeClimate.
Black used.
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    844c21d View commit details
    Browse the repository at this point in the history

  8. Improve: save consonants repeaters for improve speed 

    TODO resolved, black used, test passed
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    1e1631f View commit details
    Browse the repository at this point in the history

  9. Refac: make repeater checking function 

    Code complexity pointed out by CodeClimate, black used
    @konbraphat51
    konbraphat51 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ceb9d76 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Refac: seperate function

    @konbraphat51
    konbraphat51 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    6509e0d View commit details
    Browse the repository at this point in the history

  2. Improve: Rename method 

    suggested by PyThaiNLP#862 (comment)
    @konbraphat51
    konbraphat51 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9c1a34c View commit details
    Browse the repository at this point in the history

  3. Refac: make names more clear

    @konbraphat51
    konbraphat51 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    24c3050 View commit details
    Browse the repository at this point in the history

  4. Refac: reflect method name change

    @konbraphat51
    konbraphat51 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    13cf54a View commit details
    Browse the repository at this point in the history

  5. Fix: argument inconsistence

    @konbraphat51
    konbraphat51 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a94fccb View commit details
    Browse the repository at this point in the history