[ignore] Enable from-source patchelf in wheel builds
#19265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviving parts of RobotLocomotion#18163 to help enable testing for `patchelf` folks if desired.
|
@drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-release please. this build is expected to fail, using commit of 0.18.0 which is what is broken |
Successful failure as desired from https://drake-jenkins.csail.mit.edu/job/linux-focal-unprovisioned-gcc-wheel-experimental-release/18/consoleFull |
svenevs
commented
Apr 24, 2023
Comment on lines
+10
to
+11
| set(patchelf_url "https://github.com/NixOS/patchelf/tarball/99c24238981b7b1084313aca8f5c493bb46f302c") | ||
| set(patchelf_md5 "9fa63224f9b73060ef6bd37f8effea8c") |
There was a problem hiding this comment.
In order to test anything, a commit has to be pushed due to the other mechanics of the build. You will need to curl -LO https://github.com/NixOS/patchelf/tarball/${commit} and get the corresponding md5sum of said artifact, otherwise the build will reject well before any errors come up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving parts of #18163 to help enable testing for
patchelffolks if desired.Relates: #19261
To test, you will need to
bazel. Currently drake's setup scripts do this, you will likely need exactlybazel6.1.1.docker-ceanddocker-buildx-plugin. Bazel ultimately launches a docker build. This can only be done on linux. The mac build is much harder to orchestrate, windows not supported.eval $(ssh-agent -s)bazel run //tools/wheel:builder -- --python 38 0.1.0(make sure tocdto the top-leveldrakegit repository to run that command).Do note that this may not be a good working test case, there is a lot of machinery and the wheel build takes a long time (it also builds VTK and a bunch of dependencies, in addition to drake...). However, we would happily test any new commit, see review comment below -- if there is a commit pushed, I can funnel it through our CI or build it locally fairly easily.
This change is