[common,geometry] Remove inline destructors #22030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
release notes: fix
jwnimmer-tri
force-pushed
the
inline-dtors-common-geometry
branch
from
b3d4d0e
to
74ad25f
Compare
|
+@SeanCurtis-TRI for both(?) reviews, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22015.
I believe this corrects all of the virtual inline destructors in non-test, non-dev header files.
I also fixed many of the non-virtual destructors that were also not supposed to be inline, but I wasn't as thorough on those so some might remain. That's fine, we can deal with them later.
This change is