Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docu #146

Merged
merged 6 commits into from
Aug 4, 2021
Merged

Update Docu #146

merged 6 commits into from
Aug 4, 2021

Conversation

wurzka
Copy link
Contributor

@wurzka wurzka commented Aug 4, 2021

Mention the reusable interface
Naming Convention
New Annotations
Updated example

wurzka added 3 commits August 4, 2021 08:39
Mention the reusable interface
Naming Convention
New Annotations
Updated example
@larshp
Copy link
Collaborator

larshp commented Aug 4, 2021

A: file naming, suggest adding information as to what a "object type" is, personally I assume its a R3TR object, see #115
B: "Extreme Values", is this feature needed? I expect the schema generation to be based on the ABAP types
C: "Length Specification", is this feature needed? I expect the schema generation to be based on the ABAP types
D: "Default", is this feature needed? I expect the schema generation to be based on the ABAP types update: for types I guess its not possible to define a default, anyhow, suggest deferring and opening an issue for it, this is nice-to-have

I suggest prioritizing getting the schema generation running/automated first, instead of adding more features

@wurzka
Copy link
Contributor Author

wurzka commented Aug 4, 2021

See #144. There is talked about the need for the new annotation.

@larshp
Copy link
Collaborator

larshp commented Aug 4, 2021

heh, okay, I don't follow any of the new format files, only INTF + CHKO

@wurzka wurzka requested a review from schneidermic0 August 4, 2021 08:06
@schneidermic0
Copy link
Contributor

Relates to #128, but won't closes it until the interface names have been adapted

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@wurzka wurzka merged commit 5086ac4 into main Aug 4, 2021
@wurzka wurzka deleted the docu/update-documentation branch August 4, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants