Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFPF] Add new object type SFPF #567

Merged
merged 43 commits into from
May 28, 2024
Merged

[SFPF] Add new object type SFPF #567

merged 43 commits into from
May 28, 2024

Conversation

Bomberus
Copy link
Member

@Bomberus Bomberus commented Nov 8, 2023

No description provided.

Add AFF Type SFPF
Copy link

cla-assistant bot commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Nov 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

[SFPF] Change domain specific data type to generic ones
@schneidermic0 schneidermic0 self-requested a review November 9, 2023 15:24
Comment on lines 8 to 9
"name": "TEMPLATE_NAME",
"description": "Description",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First question:

Is name the object's name and description the object's description?

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my questions and comments below

file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. See my new comments.

I have marked some comments as newbie feedback. Maybe, this is valuable for you. Let me know, if it does not make sense.

Let me know if you need more information.

file-formats/sfpf/README.md Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sfpf/sfpf-v1.json Outdated Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json Outdated Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Outdated Show resolved Hide resolved
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Here are two more, small suggestions.

file-formats/sfpf/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bomberus, Thanks! Looks good to me, now

@schneidermic0 schneidermic0 requested a review from a team December 7, 2023 09:03
@albertmink albertmink added the new-object This is a new object type added to AFF label Dec 7, 2023
@albertmink
Copy link
Contributor

albertmink commented Dec 13, 2023

@Bomberus are you ready to merge? I can overrule the pending checks manually. They are meaningless, since the checks got renamed/restructured in #574. The green ones are the important ones 😄

But UX review first.

Bomberus

This comment was marked as duplicate.

Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the change. LGTM :)

@wurzka wurzka merged commit 9a57bc3 into SAP:main May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants