Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFPF] Add new object type SFPF #567

Merged
merged 43 commits into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
1daa7e3
Add AFF Type SFPF
Bomberus Nov 8, 2023
a5bbff8
[SFPF] Data Type fix
Bomberus Nov 9, 2023
ebf9e26
Update zif_aff_sfpf_v1.intf.abap
Bomberus Nov 9, 2023
29cbb05
Update zif_aff_sfpf_v1.intf.abap
Bomberus Nov 9, 2023
e90d796
Fix example
Bomberus Nov 9, 2023
d29b78f
Update z_aff_example_sfpf.sfpf.json
Bomberus Nov 9, 2023
614108a
Update z_aff_example_sfpf.sfpf.json
Bomberus Nov 9, 2023
a168708
Merge branch 'main' into main
schneidermic0 Nov 10, 2023
a75bce3
Merge branch 'main' into main
schneidermic0 Nov 21, 2023
88cde14
Add files via upload
Bomberus Nov 28, 2023
06fa1d3
Update z_aff_example_sfpf.sfpf.json
Bomberus Nov 28, 2023
91ea513
Add files via upload
Bomberus Nov 28, 2023
7b4c82c
Update file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap
Bomberus Nov 28, 2023
23c734d
Update zif_aff_sfpf_v1.intf.abap
Bomberus Nov 28, 2023
8ba4942
Update file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap
Bomberus Nov 28, 2023
3e7bf5f
Update zif_aff_sfpf_v1.intf.abap
Bomberus Nov 28, 2023
4a843e3
Update zif_aff_sfpf_v1.intf.abap
Bomberus Nov 28, 2023
72f9f26
Update z_aff_example_sfpf.sfpf.json
Bomberus Nov 28, 2023
9ad7b92
Update sfpf-v1.json
Bomberus Nov 28, 2023
204318b
Update zif_aff_sfpf_v1.intf.abap
Bomberus Nov 28, 2023
1ca98be
Add files via upload
Bomberus Nov 28, 2023
cb1ffdd
Add files via upload
Bomberus Dec 1, 2023
89ef822
Add files via upload
Bomberus Dec 1, 2023
860ccdf
Update z_aff_example_sfpf.sfpf.json
Bomberus Dec 1, 2023
b3b9ff1
Update README.md
Bomberus Dec 1, 2023
7f62c62
Update README.md
Bomberus Dec 1, 2023
8873569
Add files via upload
Bomberus Dec 6, 2023
d3b92c5
Add files via upload
Bomberus Dec 6, 2023
41596f9
Update z_aff_example_sfpf.sfpf.json
Bomberus Dec 6, 2023
f61fcee
Merge branch 'main' into main
albertmink Dec 7, 2023
448d953
Merge branch 'main' into main
albertmink Dec 12, 2023
0b6999d
Merge branch 'main' into main
albertmink Dec 13, 2023
501e8ef
Merge branch 'main' into main
schneidermic0 Dec 22, 2023
a0ba176
Merge branch 'main' into main
schneidermic0 Jan 9, 2024
7286679
Merge branch 'main' into main
schneidermic0 Feb 2, 2024
8abd1d0
Merge branch 'main' into main
schneidermic0 Mar 1, 2024
6e9e7d4
Merge branch 'main' into main
albertmink Mar 27, 2024
2b0aaf6
Merge branch 'main' into main
schneidermic0 Apr 10, 2024
3bc02fc
Fix schema due to changes in issue #582
schneidermic0 Apr 10, 2024
8e4ecf6
Merge branch 'main' into main
schneidermic0 Apr 12, 2024
44ce75f
Merge branch 'main' into main
schneidermic0 Apr 12, 2024
3b4af15
Update file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap
Bomberus May 27, 2024
a8d14b4
fix typo dataprovider
Bomberus May 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions file-formats/sfpf/README.md
schneidermic0 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# SFPF File Format

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf.json)
13 changes: 13 additions & 0 deletions file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"formatVersion": "1",
"header": {
"description": "Example SFPF for ABAP file formats",
"originalLanguage": "en",
"abapLanguageVersion": "cloudDevelopment"
},
"name": "TEMPLATE_NAME",
"description": "Description",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First question:

Is name the object's name and description the object's description?

"dataprovider": "Example_SRV_DEF",
"embed": false,
"mirroring": false
}
99 changes: 99 additions & 0 deletions file-formats/sfpf/sfpf-v1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
{
"$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/sfpf/sfpf-v1.json",
"title": "Object Type SFPF",
"description": "Object type SFPF",
"type": "object",
"properties": {
"formatVersion": {
"title": "Format Version",
"description": "Format version",
"type": "string",
"const": "1"
},
"header": {
"title": "Header",
"description": "Header",
"type": "object",
"properties": {
"description": {
"title": "Description",
"description": "Description of the ABAP object",
"type": "string",
"maxLength": 60
},
"originalLanguage": {
"title": "Original Language",
"description": "Original language of the ABAP object",
"type": "string",
"minLength": 2,
"maxLength": 2,
"pattern": "^[a-z]+$"
},
"abapLanguageVersion": {
"title": "ABAP Language Version",
"description": "ABAP language version",
"type": "string",
"enum": [
"standard",
"keyUser",
"cloudDevelopment"
],
"enumTitles": [
"Standard",
"ABAP for Key Users",
"ABAP Cloud Development"
],
"enumDescriptions": [
"Standard",
"ABAP for key user extensibility",
"ABAP cloud development"
],
"default": "standard"
}
},
"additionalProperties": false,
"required": [
"description",
"originalLanguage"
]
},
"name": {
"title": "Name",
"description": "Name",
"type": "string",
"maxLength": 30
},
"description": {
"title": "Description",
"description": "Description",
"type": "string",
"maxLength": 60
},
"dataprovider": {
"title": "Dataprovider",
"description": "Dataprovider",
"type": "string",
"maxLength": 40
},
"embed": {
"title": "Font Embed",
"description": "Font Embed",
"type": "boolean"
},
"mirroring": {
"title": "Mirror in RTL",
"description": "Mirror in RTL",
"type": "boolean"
}
},
"additionalProperties": false,
"required": [
"formatVersion",
"header",
"name",
"description",
"dataprovider"
]
}
34 changes: 34 additions & 0 deletions file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
INTERFACE zif_aff_sfpf_v1
PUBLIC.
TYPES:
"! <p class="shorttext">Object Type SFPF</p>
"! Object type SFPF
BEGIN OF ty_main,
"! <p class="shorttext">Format Version</p>
"! Format version
"! $required
format_version TYPE zif_aff_types_v1=>ty_format_version,
"! <p class="shorttext">Header</p>
"! Header
"! $required
header TYPE zif_aff_types_v1=>ty_header_60,
Bomberus marked this conversation as resolved.
Show resolved Hide resolved
"! <p class="shorttext">Name</p>
"! Name
"! $required
name TYPE c LENGTH 30,
"! <p class="shorttext">Description</p>
"! Description
"! $required
description TYPE c LENGTH 60,
Bomberus marked this conversation as resolved.
Show resolved Hide resolved
"! <p class="shorttext">Dataprovider</p>
"! Dataprovider
"! $required
dataprovider TYPE c LENGTH 40,
"! <p class="shorttext">Font Embed</p>
"! Font Embed
embed TYPE abap_bool,
"! <p class="shorttext">Mirror in RTL</p>
"! Mirror in RTL
mirroring TYPE abap_bool,
Bomberus marked this conversation as resolved.
Show resolved Hide resolved
Bomberus marked this conversation as resolved.
Show resolved Hide resolved
END OF ty_main.
ENDINTERFACE.
7 changes: 7 additions & 0 deletions file-formats/sfpf/type/zif_aff_sfpf_v1.intf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"formatVersion": "1",
"header": {
"description": "AFF type for SFPF object",
"originalLanguage": "en"
}
}
Loading