-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCP1]Add default value and rename constant name #573
Conversation
|
file-formats/scp1/README.md
Outdated
:--- | :--- | :--- | :--- | :--- | ||
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [`z_aff_example_scp1.scp1.json`](./examples/z_aff_example_scp1.scp1.json) | ||
:--- | :--- | :--- | :--- | :--- | ||
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [z_aff_example_scp1.scp1.json](./examples/z_aff_example_scp1.scp1.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [z_aff_example_scp1.scp1.json](./examples/z_aff_example_scp1.scp1.json) | |
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [`z_aff_example_scp1.scp1.json`](./examples/z_aff_example_scp1.scp1.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An there too much spaces which have been added but I cannot add them to my suggestion. You may remove them manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be fixed in the report because I can see that same spaces are available in the file generated from report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... can you please fix it anyway? Also the "`" was removed
file-formats/scp1/README.md
Outdated
:--- | :--- | :--- | :--- | :--- | ||
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [`z_aff_example_scp1.scp1.json`](./examples/z_aff_example_scp1.scp1.json) | ||
:--- | :--- | :--- | :--- | :--- | ||
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [z_aff_example_scp1.scp1.json](./examples/z_aff_example_scp1.scp1.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An there too much spaces which have been added but I cannot add them to my suggestion. You may remove them manually
@goreraks the check // cc. @marcushoepfner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! I have some small suggestions related to your changes.
If you adapt these, the schema needs to be generated, again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can still change SCP1 incompatible, because there is no usage of it (e.g., in abapGit), yet.
Therefore, Looks good to me.
file-formats/scp1/README.md
Outdated
:--- | :--- | :--- | :--- | :--- | ||
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [`z_aff_example_scp1.scp1.json`](./examples/z_aff_example_scp1.scp1.json) | ||
:--- | :--- | :--- | :--- | :--- | ||
`<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [z_aff_example_scp1.scp1.json](./examples/z_aff_example_scp1.scp1.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... can you please fix it anyway? Also the "`" was removed
@schneidermic0 can you pls. double check and approve if ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! But I want to wait merging the changes until the tests were executed
Merging and overruling the checks. |
Refers to #396