-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCP1]Add default value and rename constant name #573
Merged
+4,623
−23,077
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b0c5550
Add default value and rename constant name
goreraks ad93149
fix json example error
goreraks c4a024b
fix json example error
goreraks 7f9dc9e
Fix title error
goreraks add88c7
Merge branch 'main' into updateSCP1FileFormat
schneidermic0 ac2812b
Fix Review Comments
goreraks 7ab99bd
Update README.md
goreraks de75362
Merge branch 'main' into updateSCP1FileFormat
albertmink File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # SCP1 File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [`z_aff_example_scp1.scp1.json`](./examples/z_aff_example_scp1.scp1.json) | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.scp1.json` | 1 | [`zif_aff_scp1_v1.intf.abap`](./type/zif_aff_scp1_v1.intf.abap) | [`scp1-v1.json`](./scp1-v1.json) | [z_aff_example_scp1.scp1.json](./examples/z_aff_example_scp1.scp1.json) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An there too much spaces which have been added but I cannot add them to my suggestion. You may remove them manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be fixed in the report because I can see that same spaces are available in the file generated from report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... can you please fix it anyway? Also the "`" was removed