Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated JSON Schema available in PR #574

Merged
merged 22 commits into from
Dec 12, 2023

Conversation

albertmink
Copy link
Contributor

@albertmink albertmink commented Dec 6, 2023

  • upload generated JSON Schema in GitHub Action
  • improve readability in error scenario by creating annotations
Screenshot 2023-12-11 at 14 32 07

@albertmink

This comment was marked as outdated.

@larshp
Copy link
Collaborator

larshp commented Dec 6, 2023

alternatively/supplement by adding it as an artifact to the run

https://github.com/actions/upload-artifact

@albertmink
Copy link
Contributor Author

albertmink commented Dec 6, 2023

yeahh, upload does zip the content. This means, you want to see the content, then download, unzip, open with editor. For me this is too much, if you only are interested in having a glimpse.
I'm still not sure what to do with the generated schema. But as they are generated anyhow, it felt intuitive to make the result somehow available. Somehow -> just paste in the GitHub Action logs.

/// edit
Size of the entire log of the JSON Schema generation Action is around 500 KB (10000Lines). So, file size should not be a problem.

@albertmink albertmink marked this pull request as ready for review December 11, 2023 13:29
@albertmink albertmink merged commit 466f958 into main Dec 12, 2023
8 checks passed
@albertmink albertmink deleted the minka/show-generated-schema branch December 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants