Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COTA] Feature only http #590

Merged
merged 35 commits into from
Mar 19, 2024
Merged

[COTA] Feature only http #590

merged 35 commits into from
Mar 19, 2024

Conversation

WUEHR
Copy link
Contributor

@WUEHR WUEHR commented Mar 6, 2024 •
edited
Loading

We reduced the "communication type" to "HTTP". In a first version we plan to support "HTTP", only. In later releases we plan to provide further options like "RFC".

WUEHR and others added 28 commits July 20, 2023 09:41
@WUEHR
Add files for COTA
6090ae2
@WUEHR
React to abaplint
665be5c
@WUEHR
React to abaplint
7dbe54a
@WUEHR
React to abaplint
9cc152a
@WUEHR
React to abaplint
33a73dc
@WUEHR
Delete duplicates
ac7e477
@WUEHR
Correct review hints
d3687da
@WUEHR
Change Data Type and Grouping
6bb32a0
@WUEHR
Change format
dca53fa
@WUEHR
Corrections of Review
1dbdad1
@WUEHR
Correct Folgder Structure and README
6631991
@WUEHR
Comment out 'Asynchronous'
7248491
@schneidermic0
Merge branch 'main' into main
7e8caa9
@schneidermic0
Merge branch 'main' into main
635eb14
@wurzka
Merge branch 'main' into main
13abf28
@WUEHR
UX Review corrections
7f1b38d
@WUEHR
Correction of more Typos
4c93368
@schneidermic0
Merge branch 'main' into main
1736376
@schneidermic0
Merge branch 'main' into main
9938764
@WUEHR
Changes to the RFC part
3104915
@WUEHR
Change to 'Communication Target Class'
f652e6f
@schneidermic0
Merge branch 'main' into main
d41faa7
@WUEHR
Delete RFC Type Field
2bf7df3
@albertmink
Restart GitHub Action 'abaplint'
b0c9825
@WUEHR
Merge branch 'SAP:main' into main
cd88a4a
@WUEHR
Reduce COTA object to HTTP
0a3606d
@WUEHR
Commit COTA without RFC
89792a7
@WUEHR
Commit example
25cb7e8
@albertmink albertmink mentioned this pull request Mar 6, 2024
Open
@albertmink albertmink requested a review from a team March 6, 2024 14:33
schneidermic0
schneidermic0 requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WUEHR for updating the file format to the latest version 👍

Since the object type is still in development we can still change it "incompatible".

See my questions and there is one typo.

file-formats/cota/type/zif_aff_cota_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/cota/cota-v1.json Show resolved Hide resolved
file-formats/cota/type/zif_aff_cota_v1.intf.abap Outdated Show resolved Hide resolved
schneidermic0
schneidermic0 reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principal it looks good to me. Let me know whether you plan to rename also the field to client_specific.

schneidermic0
schneidermic0 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
As soon as @SAP/abap-file-formats-ux approves, we can merge the change.

albertmink
albertmink reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WUEHR.

Just let us know whether you plan to adopt our suggestions.

file-formats/cota/type/zif_aff_cota_v1.intf.abap Show resolved Hide resolved
file-formats/cota/type/zif_aff_cota_v1.intf.abap Outdated Show resolved Hide resolved
@albertmink albertmink changed the title Feature/cota only http [COTA] Feature only http Mar 15, 2024
@albertmink albertmink requested a review from a team March 19, 2024 08:18
albertmink
albertmink approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WUEHR, changes LGTM

@schneidermic0 schneidermic0 merged commit 552f60a into SAP:main Mar 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 approved these changes

@albertmink albertmink albertmink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WUEHR @albertmink @schneidermic0 @wurzka