Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COTA] Feature only http #590

Merged
merged 35 commits into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
6090ae2
Add files for COTA
WUEHR Jul 20, 2023
665be5c
React to abaplint
WUEHR Jul 20, 2023
7dbe54a
React to abaplint
WUEHR Jul 20, 2023
9cc152a
React to abaplint
WUEHR Jul 20, 2023
33a73dc
React to abaplint
WUEHR Jul 20, 2023
ac7e477
Delete duplicates
WUEHR Jul 21, 2023
d3687da
Correct review hints
WUEHR Jul 24, 2023
6bb32a0
Change Data Type and Grouping
WUEHR Jul 24, 2023
dca53fa
Change format
WUEHR Jul 24, 2023
1dbdad1
Corrections of Review
WUEHR Jul 25, 2023
6631991
Correct Folgder Structure and README
WUEHR Jul 26, 2023
7248491
Comment out 'Asynchronous'
WUEHR Jul 26, 2023
7e8caa9
Merge branch 'main' into main
schneidermic0 Jul 28, 2023
635eb14
Merge branch 'main' into main
schneidermic0 Jul 31, 2023
13abf28
Merge branch 'main' into main
wurzka Aug 2, 2023
7f1b38d
UX Review corrections
WUEHR Aug 2, 2023
4c93368
Correction of more Typos
WUEHR Aug 3, 2023
1736376
Merge branch 'main' into main
schneidermic0 Aug 4, 2023
9938764
Merge branch 'main' into main
schneidermic0 Aug 15, 2023
3104915
Changes to the RFC part
WUEHR Sep 12, 2023
f652e6f
Change to 'Communication Target Class'
WUEHR Sep 13, 2023
d41faa7
Merge branch 'main' into main
schneidermic0 Sep 14, 2023
2bf7df3
Delete RFC Type Field
WUEHR Sep 18, 2023
b0c9825
Restart GitHub Action 'abaplint'
albertmink Sep 19, 2023
cd88a4a
Merge branch 'SAP:main' into main
WUEHR Mar 6, 2024
0a3606d
Reduce COTA object to HTTP
WUEHR Mar 6, 2024
89792a7
Commit COTA without RFC
WUEHR Mar 6, 2024
25cb7e8
Commit example
WUEHR Mar 6, 2024
22c3d3f
Correct RFC settings
WUEHR Mar 6, 2024
5eb42e4
Typo
WUEHR Mar 6, 2024
2e6bf90
Typo Correction
WUEHR Mar 7, 2024
d9716c0
Correct typos
WUEHR Mar 7, 2024
1385c48
Replace client_dependent
WUEHR Mar 8, 2024
def8e28
New Order of Fields
WUEHR Mar 18, 2024
3bd3c28
Merge branch 'main' into feature/cota_only_http
wurzka Mar 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions file-formats/cota/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# COTA File Format


File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.cota.json` | 1 | [`zif_aff_cota_v1.intf.abap`](./type/zif_aff_cota_v1.intf.abap) | [`cota-v1.json`](./cota-v1.json)
`<name>.cota.json` | 1 | [`zif_aff_cota_v1.intf.abap`](./type/zif_aff_cota_v1.intf.abap) | [`cota-v1.json`](./cota-v1.json) | [`sap_cota_testobject.cota.json`](./examples/sap_cota_testobject.cota.json)
WUEHR marked this conversation as resolved.
Show resolved Hide resolved
24 changes: 17 additions & 7 deletions file-formats/cota/cota-v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,12 @@
"description": "Communication type",
"type": "string",
"enum": [
"rfc",
"http"
WUEHR marked this conversation as resolved.
Show resolved Hide resolved
],
"enumTitles": [
"RFC",
"HTTP"
],
"enumDescriptions": [
"RFC",
"HTTP"
],
"default": "http"
Expand All @@ -90,10 +87,23 @@
"description": "Allow multiple application destinations",
"type": "boolean"
},
"clientIndependent": {
"title": "Allow Client Independent Application Destinations",
"description": "Allow client independent application destinations",
"type": "boolean"
"multitenancyMode": {
"title": "Multitenacy Mode",
"description": "Multitenancy mode",
"type": "string",
"enum": [
"crossClient",
"clientDependent"
],
"enumTitles": [
"Cross Client",
"Client Specific"
],
"enumDescriptions": [
"Cross client",
"Client dependent"
],
"default": "clientDependent"
}
},
"additionalProperties": false
Expand Down
12 changes: 12 additions & 0 deletions file-formats/cota/examples/sap_cota_testobject.cota.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"formatVersion": "1",
"header": {
"description": "Object For Unit Tests",
"originalLanguage": "en"
},
"configuration": {
"communicationTargetClass": "SAP_COTA_TESTOBJECT",
"multitenancyMode": "crossClient"
},
"rfcSettings": {}
WUEHR marked this conversation as resolved.
Show resolved Hide resolved
}
30 changes: 22 additions & 8 deletions file-formats/cota/type/zif_aff_cota_v1.intf.abap
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,27 @@ INTERFACE zif_aff_cota_v1
"! <p class="shorttext">Communication Type</p>
"! Communication type
BEGIN OF co_comm_type,
"! <p class="shorttext">RFC</p>
"! RFC
rfc TYPE ty_comm_type VALUE 'R',
"! <p class="shorttext">HTTP</p>
"! HTTP
http TYPE ty_comm_type VALUE 'H',
END OF co_comm_type.

"! <p class="shorttext">Multitenancy Mode</p>
"! $values {@link zif_aff_cota_v1.data:co_multimode_type}
TYPES ty_multi_type TYPE c LENGTH 30.
WUEHR marked this conversation as resolved.
Show resolved Hide resolved

CONSTANTS:
"! <p class="shorttext">Multitenancy Mode</p>
"! Multitenancy mode
BEGIN OF co_multimode_type,
"! <p class="shorttext">Cross Client</p>
"! Cross client
cross_client TYPE ty_multi_type VALUE 'C',
"! <p class="shorttext">Client Specific</p>
"! Client dependent
client_dependent TYPE ty_multi_type VALUE 'D',
WUEHR marked this conversation as resolved.
Show resolved Hide resolved
END OF co_multimode_type.

TYPES:
"! <p class="shorttext">Configuration</p>
"! Configuration
Expand All @@ -28,13 +41,14 @@ INTERFACE zif_aff_cota_v1
communication_type TYPE ty_comm_type,
"! <p class="shorttext">Communication Target Class</p>
"! Communication target class
communication_target_class TYPE zif_aff_types_v1=>ty_object_name_30,
communication_target_class TYPE zif_aff_types_v1=>ty_object_name_30,
"! <p class="shorttext">Allow Multiple Application Destinations</p>
"! Allow multiple application destinations
allow_multiple_destinations TYPE abap_bool,
WUEHR marked this conversation as resolved.
Show resolved Hide resolved
"! <p class="shorttext">Allow Client Independent Application Destinations</p>
"! Allow client independent application destinations
client_independent TYPE abap_bool,
"! <p class="shorttext">Multitenacy Mode</p>
WUEHR marked this conversation as resolved.
Show resolved Hide resolved
"! Multitenancy mode
"! $default {@link zif_aff_cota_v1.data:co_multimode_type.client_dependent}
multitenancy_mode TYPE ty_multi_type,
END OF ty_configuration.

"! <p class="shorttext">Default Compression Mode</p>
Expand All @@ -60,7 +74,7 @@ INTERFACE zif_aff_cota_v1
BEGIN OF ty_rfc_settings,
"! <p class="shorttext">Enforce SAP GUI Support</p>
"! Enforce SAP GUI support
enforce_sap_gui_support TYPE abap_bool,
enforce_sap_gui_support TYPE abap_bool,
"! <p class="shorttext">Enforce Fast Serialization</p>
"! Enforce fast serialization
enforce_fast_serialization TYPE abap_bool,
Expand Down
Loading