Updated MCPWM Implementation for servo control to support ESP-IDF 5.0 (#90) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aPR0T0
reviewed
Apr 10, 2024
src/servo.c
Outdated
| } | ||
|
|
||
| static esp_err_t set_angle_servo_helper(int servo_pin, int servo_max, int servo_min_pulsewidth, int servo_max_pulsewidth, unsigned int degree_of_rotation, mcpwm_unit_t mcpwm_num, mcpwm_timer_t timer_num, mcpwm_generator_t gen) | ||
| static esp_err_t set_angle_servo_helper(int servo_pin, int servo_max, int servo_min_pulsewidth, int servo_max_pulsewidth, int cmp_num, unsigned int degree_of_rotation) |
There was a problem hiding this comment.
cmp_num is used and just 0 or 1 is the value, then how will it identify which out of 4 motors are going to turn?
aPR0T0
requested changes
Apr 12, 2024
SuperChamp234
requested changes
Apr 12, 2024
| #endif |
There was a problem hiding this comment.
Please fix these types of newline diffs. They are unnecessary.
There was a problem hiding this comment.
There is a lot of repetitive logic in this code. Can’t we just create an object of the servo for three different GPIOs? Hardcoding this seems unnecessary.
aPR0T0
reviewed
Apr 13, 2024
There was a problem hiding this comment.
Can you please share testing results?
Refactor the structs in mario-repo
aPR0T0
approved these changes
Apr 14, 2024
|
@SuperChamp234 I think this fork is ready to be merged, please share your reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added v5.1 ESP-IDF support for servo control