-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): distribution registry can be set global and individual component #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
…HQ#2018 Signed-off-by: Viet Nguyen Duc <[email protected]>
diemol
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge, thank you!
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
feat(chart): distribution registry can be set global and individual component
Motivation and Context
Currently, image registry is set static value
selenium/
, it means the image will be pulled from the Selenium repo on Docker Hub. However, some organizations are hosting their private mirror repo, artifactory to reduce the internet connection reach, moreover, Docker Hub also has their rate limit. Also for different purposes, user is able to set registry for all or individual componentIt would be better chart has a config for the image registry at global and could be overridden in individual components if needed. When deploying a chart, config can be set
helm upgrade -i RELEASENAME --set global.seleniumGrid.imageRegistry=artifactiory.mydomain.com/selenium --set chromeNode.imageRegistry=nexus-repo.mydomain.com/selenium [--set ...] selenium-grid
Update sanity tests for chart (cont test(chart): Sanity tests Selenium Grid chart via Makefile commands #2029 )
Remove redundant
if
statement in workflowUpdate for released notes to extract Chrome version after PR feat: Update NodeChrome support latest version from GoogleChromeLabs #2018 properly
Types of changes
Checklist