Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xz: Update from version 5.6.1+really5.4.5 to 5.6.2 #6210

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Aug 29, 2024

Description

  1. xz: Update from version 5.6.1+really5.4.5 to 5.6.2
  2. Fix python 3.10-3.11 builds.
  3. Fix build issue for hi3535 related to fd-8.7.0 with newer rustc >= 1.80.1 (now version fixed to 1.77.2 like ARMv5)

Superseeds part of #6200

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

TODO

@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2024

@th0ma7 be aware that the build uses now the debian 12 image.

ntopng fails, because it patches the configure file that was created in pre_patch with @$(RUN) ./autogen.sh
The former docker image had GNU Autoconf 2.69 but now it uses GNU Autoconf 2.71 and this creates a different configure file that can't be patched with the existing patches anymore.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 30, 2024

@th0ma7 be aware that the build uses now the debian 12 image.

ntopng fails, because it patches the configure file that was created in pre_patch with @$(RUN) ./autogen.sh The former docker image had GNU Autoconf 2.69 but now it uses GNU Autoconf 2.71 and this creates a different configure file that can't be patched with the existing patches anymore.

yup, i got that. I have a pending PR locally (will upload shortly, perhaps tomorrow) that updates to the latest version. It builds for all arches except armv5 and armv7l no longer supported (AFAICS). If you have a moment to assist, left are converting from src/start-stop-status.sh to src/service-setup.sh and testing (of course).

@th0ma7 th0ma7 mentioned this pull request Aug 30, 2024
10 tasks
@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 30, 2024

@hgy59 there is still some work left over but I've now uploaded my changes in #6216

Your assistance is more than welcomed :)

@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2024

yup, i got that. I have a pending PR locally (will upload shortly, perhaps tomorrow) that updates to the latest version. It builds for all arches except armv5 and armv7l no longer supported (AFAICS). If you have a moment to assist, left are converting from src/start-stop-status.sh to src/service-setup.sh and testing (of course).

When looking in #4524, ntopng will not run on DSM 7 as it must be run as root.
This could be bypassed by manually patching the privilege file as post installation task (we startet to think about this in #6152 and #6077).

BTW: the start-stop-status.sh script is not an issue for DSM 7 (in the wiki I only recommended to avoid it, if possible).

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 1, 2024

@hgy59 I was finally able to reproduce the python issue, which only hapens in docker (I use lxc/lxd). Now a matter of figuring why... but that's a start.

@hgy59
Copy link
Contributor

hgy59 commented Sep 1, 2024

@hgy59 I was finally able to reproduce the python issue, which only hapens in docker (I use lxc/lxd). Now a matter of figuring why... but that's a start.

Just a small hint.
When building ntopng (#6218) with debian 11 and debian 12 docker images, I found that with the old debian 11 image, the meson version is 1.4.0 but the new debain 12 image has older meson version 1.0.1.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 2, 2024

@hgy59 things are nicely coming along. One exception so far: synocli-file for hi3535. I'll try to reproduce but wondered, does this ring any bell?

@Safihre
Copy link
Contributor

Safihre commented Sep 3, 2024

Maybe rename this PR since it's so much more than just xz?

@th0ma7 th0ma7 merged commit fa8b4e4 into SynoCommunity:master Sep 3, 2024
16 of 17 checks passed
@th0ma7 th0ma7 deleted the misc-updates-xz branch September 3, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants