Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: failures on uncaught exception (should use Cypress.env, not process.env) #837

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

YakovL
Copy link
Contributor

@YakovL YakovL commented Aug 17, 2023

Motivation and context

This is a follow up to #831: I've stumbled upon another issue that reproducibly produced the process is not defined error, applied my suggestion from comments and confirmed that the bug goes away indeed (process is not defined is no longer shown, the step passes).

Quality checklist

  • I have performed a self-review of my code.

Todo

  • Find whether there's a e2e test for this feature, check if it was red before and got green now

@r3kt-eth
Copy link
Contributor

thank you for this fix 🙏

@r3kt-eth r3kt-eth merged commit 3d695f8 into Synthetixio:dev Aug 17, 2023
2 of 8 checks passed
@YakovL
Copy link
Contributor Author

YakovL commented Aug 17, 2023

@r3kt-eth thanks for merging! Please take a look at #828, too

@YakovL YakovL deleted the uncaught-exceptions-handling branch August 17, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants