Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: failures on uncaught exception (should use Cypress.env, not process.env) #837

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix: failures on uncaught exception (should use Cypress.env, not process.env) #837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54c5bd2
fix: failures on uncaught exception (should use Cypress.env, not proc…
YakovL Aug 17, 2023
ba98f3b
Merge branch 'dev' into uncaught-exceptions-handling
YakovL Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions support/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ configure({ testIdAttribute: 'data-testid' });

// dont fail tests on uncaught exceptions of websites
Cypress.on('uncaught:exception', () => {
if (!process.env.FAIL_ON_ERROR) {
if (!Cypress.env('FAIL_ON_ERROR')) {
return false;
}
});
Expand All @@ -14,7 +14,7 @@ Cypress.on('window:before:load', win => {
cy.stub(win.console, 'error').callsFake(message => {
cy.now('task', 'error', message);
// fail test on browser console error
if (process.env.FAIL_ON_ERROR) {
if (Cypress.env('FAIL_ON_ERROR')) {
throw new Error(message);
}
});
Expand Down
Loading