11.0 #50
11.0 #50
Conversation
|
I'm a bit overwhelmed of work right now. The reviewing of this will be delayed some days for me. |
|
Thank you, I will review as my schedule permits. I do not use enterprise edition so I am not familiar with the differences however I will review each change on it's own merits. After this we can discuss the necessary steps in moving this to OCA. |
|
Hi @SythilTech, we used Enterprise as a comparison just to tidy the UI and make it more integrated with Odoo default views. Also that'll facilitate the approval of the module in OCA. However there are some "changes" we'd like to propose, such as separate some functionalities in different modules (like website view, or your default stages, which are hard-coded and may be not useful for everyone). We can prepare it in another PR if you agree and also start to discuss it in OCA. |
|
Thank you for your patience, I have completed my review of the changes. I like a some of the changes such as including the tickets in the my account area as that centralises all documents associated to the individual. I also like priority having a more visible effect by having stars, especially since the whole coloured priority row feature has been broken since the port from 10 The neating up of the settings screen is also a nice touch. However many of these changes are not upgrade friendly, for example existing tickets state and priority information is lost upon upgrading the module. There are also a few bugs such as the email link that allows people without users accounts to view there ticket / conversation history returning a 404 due to it using the composer id and not the ticket id. I also agree that the module should be split on it's dependencies, this would allow people to have the email support ticket functionality without also installing the website, Overall I feel all these changes should be made into spin off modules especially if website_support will have the website parts of it detached into a separate module. |
|
Do you need extra help or work to do in order to merge the PR? |
|
Hello, As some of these changes in this PR cause data loss for those upgrading from the current or older version I will likely not accept this PR. These changes may serve better as a fork or new version of the module for people that are starting fresh. |
|
Hi @SythilTech, IMHO I believe forking the project and dividing efforts won't be a good idea. The biggest and strongest the community are, the best for the project. That said, I think the approach of the PR is more standard or generic to be used in any kind of company, so do you believe there is any chance to develop an scripts to migrate to the new approach so we can combine all efforts in one plattform and even migrate it to OCA? We'll try to help in anything we can to get more community and users. Thanks again :) |
|
Hi @dxnacho Yes migrations scripts could be developed. The data could be moved from state model to stage model, there my also need to be updates to some of the extension modules that would be referencing state to maintain comparability. The settings data could also be moved across, ideally people upgrading from an older version should have the help pages and SLA active to prevent confusion on them suddenly being removed or if possible some notification about the change as many skip reading over the changelog. The priority migration would be trickier as some users may have created custom priorities which can't easily be automatically mapped to a 1-5 system. It would also be good if the customers ability to close tickets was preserved through the use of the new ticket interface. As long as features and user data is preserved I am fine with internal re codes and UI changes. |
|
Can we divide efforts then to develop all this scripts and continue improving your modules? :) |
|
Yes I can do some of these migration scripts, It might be a week or two before I can begin though |
|
Ok, let us know if you need something. Cheers. |
|
Hello, count me in at Akretion to suggest moving this module to the OCA. I did 2 cleanup PRs against the 12.0 branch while I missed this refactor onn 11.0 sadly. I think if that was at the OCA we could work on that on a more integrated manner and you would also have the prestige of having modules accepted in the OCA which in turn may balance the more discrete branding the OCA requires. |
Hi, this is Carlos from Domatix Team. First of all, you did an amazing work with website_support module and we'd like to help with the development and some small improvements. We are currently working just on 11 version.
Our main goal is to help this module to move to OCA and also make it as similar as possible to the Enterprise module (without losing functionalities).
List of changes
Drop-down menu item Support, with the diferents options.
Tickets in my account.
Redesign of kanban view.
Priority with stars.
Changed "state" name for "stage".
Changed "portal_acces_key" for "access_token".
Redesign of settings.
SLA, Groups and Help pages in settings for enable/disable.