Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc-adapter dependency changed to npm dependency from git submodule #282

Closed
wants to merge 0 commits into from
Closed

Conversation

NTARelix
Copy link
Contributor

AdapterJS depends on webrtc/adapter (webrtc-adapter on npm). We currently declare this dependency via git submodules when ideally it would be in package.json. There are multiple reasons for this (one of which I've run into with bug #262, as well as being unable to install this dependency in a minimal CI slave that doesn't have git).

The build involves hooking into the npm lifecycle (see postinstall in package.json) to build this webrtc-adapter dependency before injecting it into this package's output. I've removed the submodule in favor of a pre-built npm dependency.

@johache
Copy link
Contributor

johache commented Aug 11, 2017

I think that this is very good idea.
We never merge anything straight into master though. Could you change your PR so that it goes into dev instead ?

Thanks,
J-O H

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants