webrtc-adapter dependency changed to npm dependency from git submodule #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdapterJS depends on webrtc/adapter (
webrtc-adapter
on npm). We currently declare this dependency via git submodules when ideally it would be inpackage.json
. There are multiple reasons for this (one of which I've run into with bug #262, as well as being unable to install this dependency in a minimal CI slave that doesn't have git).The build involves hooking into the npm lifecycle (see
postinstall
inpackage.json
) to build thiswebrtc-adapter
dependency before injecting it into this package's output. I've removed the submodule in favor of a pre-built npm dependency.