IT file changes- TestFramework.scala, Runner.scala, RunnerFactory.java #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglam
reviewed
Oct 3, 2024
| loader.loadClass(methodAnnotationStr).asInstanceOf[Class[_ <: Annotation]] | ||
|
|
||
| try { | ||
|
|
There was a problem hiding this comment.
Remove most empty lines please
| val classFilePath = clz.getProtectionDomain.getCodeSource.getLocation.getPath | ||
| val isIntegrationTestByDirectory = classFilePath.contains("/target/test-classes/") | ||
|
|
||
| Logger.getGlobal().log(Level.INFO, s"Class $clzName integration test by name: $isIntegrationTestByName") |
There was a problem hiding this comment.
Instead of adding debug messages to INFO logging, please change the level to DEBUG or something equivalent.
|
|
||
| val isIntegrationTestByName = clzName.endsWith("IT") | ||
| val classFilePath = clz.getProtectionDomain.getCodeSource.getLocation.getPath | ||
| val isIntegrationTestByDirectory = classFilePath.contains("/target/test-classes/") |
There was a problem hiding this comment.
Are there other places in testrunner that hard codes paths? Looking specifically in /target/test-classes/ may be best to be hard coded with other paths in testrunner
| Logger.getGlobal().log(Level.INFO, s"Class $clzName integration test by name: $isIntegrationTestByName") | ||
| Logger.getGlobal().log(Level.INFO, s"Class $clzName integration test by directory: $isIntegrationTestByDirectory") | ||
|
|
||
| Try(if (methods.exists(_.getAnnotation(annotation) != null) || |
|
|
||
| if (clz.getAnnotation(disabledAnnotation) != null) { |
| .asInstanceOf[Class[_ <: Annotation]] | ||
| if (Modifier.isStatic(clz.getModifiers) || | ||
| clz.getAnnotation(nestedAnnotation) == null) { | ||
| // a nested test class should |
There was a problem hiding this comment.
We should keep these comments
| @@ -16,6 +16,8 @@ import scala.collection.mutable.ListBuffer | |||
| import scala.io.Source | |||
| import scala.util.{Failure, Try} | |||
|
|
|||
| import java.util.logging.{Level, Logger} | |||
There was a problem hiding this comment.
Wrong line. put inbetween line 4-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.