Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings name update #3021

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Python bindings name update #3021

merged 5 commits into from
Oct 13, 2023

Conversation

AadityaSuri
Copy link
Contributor

@AadityaSuri AadityaSuri commented Oct 8, 2023 •
edited by nimazareian
Loading

made the requested changes in pr #3005

resolves #2989

@nimazareian nimazareian mentioned this pull request Oct 8, 2023
Closed
nimazareian
nimazareian approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@nimazareian nimazareian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@nimazareian nimazareian requested review from a team, jyxng1 and ericlim0329 and removed request for a team October 13, 2023 02:51
williamckha
williamckha approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@williamckha williamckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done!

@AadityaSuri AadityaSuri merged commit ec23e64 into UBC-Thunderbots:master Oct 13, 2023
4 checks passed
@AadityaSuri AadityaSuri deleted the python_bindings_name_update branch October 13, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamckha williamckha williamckha approved these changes

@nimazareian nimazareian nimazareian approved these changes

@itsarune itsarune Awaiting requested review from itsarune itsarune is a code owner

@jyxng1 jyxng1 Awaiting requested review from jyxng1 jyxng1 was automatically assigned from UBC-Thunderbots/software-code-reviewers

@ericlim0329 ericlim0329 Awaiting requested review from ericlim0329 ericlim0329 was automatically assigned from UBC-Thunderbots/software-code-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update python binding import alias
3 participants
@AadityaSuri @nimazareian @williamckha