Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compile for Jetson Nano and PI Builds #3383

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

itsarune
Copy link
Contributor

Please fill out the following before requesting review on this PR

Description

#3316 broke cross-compilation on Jetson Nano and Pi builds. It was using the host gcc compiler instead of the jetson nano compiler. This enables the required toolchain resolution flag that allows bazel to use the correct compiler.

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Mr-Anyone
Copy link
Contributor

FYI: I think the cross compiler worked as I checked the binary with the command file.

@Mr-Anyone
Copy link
Contributor

Mr-Anyone commented Oct 23, 2024

However, when I ran bazel run //software/embedded/ansible:run_ansible --platforms=//cc_toolchain:robot --//software/embedded:host_platform=PI -- --playbook setup_raspberry_pi.yml --hosts random.local --ssh_pass gg

I got this error message and I am not sure where that came from:

/home/vhe/vscode/Software/src/software/power/BUILD:86:8: Executing genrule //software/power:powerloop_tar failed: (Exit 1): bash failed: error executing command /bin/bash -c ... (remaining 1 argument skipped)

It could be I have not restart my laptop?

@itsarune
Copy link
Contributor Author

Sometimes I see this if bazel isn't connected to the internet. Are you?

@Andrewyx
Copy link
Contributor

--playbook setup_raspberry_pi.yml

Why are you running this?

@Mr-Anyone
Copy link
Contributor

I just merged the two branch: this one, and Andrew's. Ansible seem to be able to flash.

@Mr-Anyone
Copy link
Contributor

--playbook setup_raspberry_pi.yml

Why are you running this?

lmao. just realized I ran the wrong thing. This is what I ran: bazel run //software/embedded/ansible:run_ansible --platforms=//cc_toolchain:robot --//software/embedded:host_platform=PI -- --playbook deploy_robot_software.yml --hosts random.local --ssh_pass gg

@Mr-Anyone
Copy link
Contributor

Mr-Anyone commented Oct 23, 2024

should we figure out why setup_raspberry_pi.yml does not work on my end or let this be a skill issues on my end?

This playbook seems to be only ran once from the look of things.

@Mr-Anyone
Copy link
Contributor

Forgot to mention, I flashed a robot successfully

@itsarune itsarune merged commit 10bded3 into UBC-Thunderbots:master Oct 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants