Major Profile Mode improvements #1443
Conversation
The current profile's name is shown on the main window, Profiles names can be custom and added buttons to export profiles to the current data.win's folder, and import them back to the appdata.
Fixed the issue where automatic comments would duplicate and the one where the custom Profile name window would show up even if Profile mode weren't enabled.
When opening a data.win, all the code in the Temp Profile folder is replaced with the main, and when saving, all the main is replaced with the temp. this, to avoid wrong overwriting. Also, exporting profiles will actually overwrite the already exported profiles, and importing too. Fixed the issue where Importing Profiles wouldn't edit the dissasembly code.
|
Download the artifacts for this pull request here: GUI:
CLI: |
Fixed a bug when using the default MD5Hash as the name for the profile when saving, and now the profile's name is the same on the folder. (In other words, the appdata folder, instead of being a MD5Hash of the Profile name, will simply be the Profile's name.)
doesn't work yet
This reverts commit f2c4e63.
it does the same but now when you close it asks if you want to save so you really don't lose that much progress!
loading a profile automatically applies its code to dissasembly plus fixed some bugs related to importing code.
|
Your PR also has the old "dogcheck" and some compiler changes that you didn't mention. |
Agreed on this -- currently we have no intention of restoring the "dogcheck" mechanism that confused many people. Also, seems like there's some extraneous compiler changes, as well as some code that maybe should be locked behind a profile mode check (e.g., checking for string comments). |
|
@Romualdo666 could you please revert the dogcheck? |
|
aight sure |
this should work, hence on should since i havent tested it out yet.
|
@Miepee that should do it |
There was a problem hiding this comment.
this iss till dogcheck related
There was a problem hiding this comment.
this is still dogcheck related
There was a problem hiding this comment.
this is still dogcheck related
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Resource Include="Resources\spr_tobdogl\0.png" /> | ||
| <Resource Include="Resources\spr_tobdogl\1.png" /> | ||
| <Resource Include="Resources\mus_dance_of_dog.wav" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
this is still dogcheck related
UndertaleModTool/MainWindow.xaml
Outdated
| <Border Background="Black" Name="room_dogcheck" Visibility="Collapsed"> | ||
| <Grid RenderOptions.BitmapScalingMode="NearestNeighbor"> | ||
| <Grid.ColumnDefinitions> | ||
| <ColumnDefinition Width="2*"/> | ||
| <ColumnDefinition Width="1*"/> | ||
| <ColumnDefinition Width="2*"/> | ||
| </Grid.ColumnDefinitions> | ||
| <Grid.RowDefinitions> | ||
| <RowDefinition Height="2*"/> | ||
| <RowDefinition Height="1*"/> | ||
| <RowDefinition Height="2*"/> | ||
| </Grid.RowDefinitions> | ||
| <Image Grid.Row="1" Grid.Column="1"> | ||
| <Image.Triggers> | ||
| <EventTrigger RoutedEvent="Loaded"> | ||
| <BeginStoryboard> | ||
| <Storyboard RepeatBehavior="Forever"> | ||
| <ObjectAnimationUsingKeyFrames Storyboard.TargetProperty="Source" | ||
| Duration="0:0:0.4"> | ||
| <DiscreteObjectKeyFrame KeyTime="0:0:0.00"> | ||
| <DiscreteObjectKeyFrame.Value> | ||
| <BitmapImage UriSource="Resources/spr_tobdogl/0.png"/> |
There was a problem hiding this comment.
this is still dogcheck related
|
oh crap i deleted the wrong file my bad. also, didnt know the assets were also needed to get deleted. i'll delete them then. |
removed dogcheck and some other changes.
|
@Miepee this was already a mess so i am just making a new pull request when i have it done, sorry. |
Description
When opening a data.win, all the code in the Temp Profile folder is replaced with the main, and when saving, all the main is replaced with the temp. this, to avoid wrong overwriting. Also, exporting profiles will actually overwrite the already exported profiles, and importing too. Fixed the issue where Importing Profiles wouldn't edit the dissasembly code.
Caveats
If you had a tab with code opened, and you import THAT code with the "Import Profile" button, it will get overwritten, but visually won't be updated until you close or switch the tab.
Notes
Sorry if I'm making too many pull request, haha.