Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 全ファイルの「スコア」を「楽譜」に統一 #1472

Merged
merged 1 commit into from
Sep 20, 2024
Merged

refactor: 全ファイルの「スコア」を「楽譜」に統一 #1472

merged 1 commit into from
Sep 20, 2024
+7 −7

Conversation

naga-na
Copy link
Contributor

@naga-na naga-na commented Sep 16, 2024

内容

  • 全ファイルの「スコア」を「楽譜」に置換しました。
    • スコアと楽譜で表記揺れしている状態のため、統一を行いたい状態でした。
    • 「ノート」は「音符」に寄せているため、日本語での表現に合わせています。

関連 Issue

ref #1461

@Hiroshiba Hiroshiba marked this pull request as ready for review September 20, 2024 15:21
@Hiroshiba Hiroshiba requested a review from a team as a code owner September 20, 2024 15:21
@Hiroshiba Hiroshiba requested review from Hiroshiba and removed request for a team September 20, 2024 15:21
Hiroshiba
Hiroshiba approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

ファイル全体から「スコア」で検索してみて、他に残ってないことを確認しました！

プルリクエストありがとうございます、またよかったらぜひ！！

@Hiroshiba Hiroshiba merged commit 37d4bfe into VOICEVOX:master Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naga-na @Hiroshiba