Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 全ファイルの「スコア」を「楽譜」に統一 #1472

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ curl -s \
> audio.wav
```

スコアの`key`は MIDI 番号です。
楽譜の`key`は MIDI 番号です。
`lyric`は歌詞で、任意の文字列を指定できますが、エンジンによってはひらがな・カタカナ1モーラ以外の文字列はエラーになることがあります。
フレームレートはデフォルトが 93.75Hz で、エンジンマニフェストの`frame_rate`で取得できます。
1つ目のノートは無音である必要があります。
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/e2e/__snapshots__/test_sing.ambr
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# serializer version: 1
# name: test_スコアとキャラクターIDから音声を合成できる
# name: test_楽譜とキャラクターIDから音声を合成できる
'MD5:1c385210acba238994604a8cee96aee3'
# ---
4 changes: 2 additions & 2 deletions test/e2e/test_sing.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
from syrupy.assertion import SnapshotAssertion


def test_スコアとキャラクターIDから音声を合成できる(
def test_楽譜とキャラクターIDから音声を合成できる(
client: TestClient, snapshot: SnapshotAssertion
) -> None:
# スコアとキャラクター ID から FrameAudioQuery を生成する
# 楽譜とキャラクター ID から FrameAudioQuery を生成する
score = {
"notes": [
{"key": None, "frame_length": 10, "lyric": ""},
Expand Down
2 changes: 1 addition & 1 deletion voicevox_engine/app/routers/tts_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def sing_frame_audio_query(
@router.post(
"/sing_frame_volume",
tags=["クエリ編集"],
summary="スコア・歌唱音声合成用のクエリからフレームごとの音量を得る",
summary="楽譜・歌唱音声合成用のクエリからフレームごとの音量を得る",
)
def sing_frame_volume(
score: Score,
Expand Down
2 changes: 1 addition & 1 deletion voicevox_engine/tts_pipeline/tts_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def create_sing_phoneme_and_f0_and_volume(
score: Score,
style_id: StyleId,
) -> tuple[list[FramePhoneme], list[float], list[float]]:
"""歌声合成用のスコア・スタイルIDに基づいてフレームごとの音素・音高・音量を生成する"""
"""歌声合成用の楽譜・スタイルIDに基づいてフレームごとの音素・音高・音量を生成する"""
notes = score.notes

(
Expand Down