Enable unsafe binary serialization #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycanardeau
commented
Dec 21, 2020
Comment on lines
+8
to
+9
| <!-- CA2300: Do not use insecure deserializer BinaryFormatter --> | ||
| <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization> |
There was a problem hiding this comment.
Can we enable unsafe binary serialization temporarily? Or should we replace it with a safe one now?
There was a problem hiding this comment.
It's ok to have this for now, but maybe add to the comment mentioning where is it being used, and note that it should be removed when possible.
ycanardeau
deleted the
feat/598-web-core-enable-unsafe-binary-serialization
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#598. See also: nhibernate/nhibernate-core#2603