Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unsafe binary serialization #700

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Enable unsafe binary serialization #700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e67b568
Enable unsafe binary serialization
ycanardeau Dec 21, 2020
0bf7750
Add comment
ycanardeau Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions VocaDbWeb.Core/VocaDbWeb.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
<RootNamespace>VocaDb.Web</RootNamespace>
<LangVersion>preview</LangVersion>
<Nullable>enable</Nullable>
<!-- Workaround for FluentNHibernate throwing Exception. This should be removed when possible. -->
<!-- CA2300: Do not use insecure deserializer BinaryFormatter -->
<EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
Comment on lines +9 to +10
Copy link
Contributor Author

@ycanardeau ycanardeau Dec 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable unsafe binary serialization temporarily? Or should we replace it with a safe one now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to have this for now, but maybe add to the comment mentioning where is it being used, and note that it should be removed when possible.

</PropertyGroup>

<ItemGroup>
Expand Down