Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Masterpiece #75

Merged
merged 30 commits into from
Oct 16, 2024
Merged

🎨 Masterpiece #75

merged 30 commits into from
Oct 16, 2024

Conversation

foglabs
Copy link
Contributor

@foglabs foglabs commented Aug 30, 2024

Masterpiece

Adds Masterpiece Collection

Misc

  • Lots of CSS fixes
  • Adds Google Analytics
  • Better Series filtering
  • PBCore types
  • AAPBRecord improvements

@foglabs foglabs mentioned this pull request Aug 30, 2024
Copy link

gitguardian bot commented Aug 30, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9607557 Triggered Generic High Entropy Secret ccfd5a8 search/search-ui.jsx View secret
9607557 Triggered Generic High Entropy Secret ccfd5a8 app/data/searchkit.json View secret
9607557 Triggered Generic High Entropy Secret b56debc search/search-ui.jsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mrharpo mrharpo added the enhancement ➕ New feature or request label Aug 30, 2024
@mrharpo mrharpo changed the title Masterpiece 🎨 Masterpiece Sep 5, 2024
foglabs and others added 2 commits September 5, 2024 17:06
…pbrecordize related_content blocks, extract constants to files'
* main:
  ⬆ Bump @types/react from 18.3.4 to 18.3.5 (#84)
  ⬆ Bump vite from 5.4.2 to 5.4.3 (#83)
  ⬆ Bump @fontsource/red-hat-text from 5.0.19 to 5.0.20 (#82)
  📟 Removes old dependencies (#81)
  ⬆ Bump postcss from 8.4.41 to 8.4.45 (#80)
  Adds dependabot config
  Fixes Hit component: link to slug 🐌
  Throw search error to activate ErrorBoundary
  Removes InstantSearchSSRProvider to fix expired elasticsearch cert crashing frontend server
  When ES cert is broken, vite crashes.
@mrharpo mrharpo linked an issue Sep 9, 2024 that may be closed by this pull request
mrharpo and others added 12 commits September 11, 2024 13:41
* main:
  ⬆ Bump the remix-dependencies group with 5 updates (#88)
  ⬆ Bump the development-dependencies group with 2 updates (#87)
  ⬆ Bump the production-dependencies group with 4 updates
  🦿 Dependabot groups
  Adds common og meta for all routes
  Updates Home meta
  Adds og meta for home page
  Extract meta logic and use in collections route
  Test og meta tags with exhibits route
…et real num records from aapb api where available, add gtm tags'
@foglabs foglabs requested a review from mrharpo October 2, 2024 18:08
@foglabs foglabs marked this pull request as ready for review October 2, 2024 18:09
…not just in data, put mp collection at front on index'
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👨‍🎨 🖌️ 💪

@foglabs foglabs merged commit 9c67ead into main Oct 16, 2024
2 checks passed
@foglabs foglabs deleted the masterpiece branch October 16, 2024 22:13
@mrharpo mrharpo mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Set up masterpiece page
2 participants