Update AMM discounted trading fee #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mDuo13
added
defi
|
Link check report. 579093 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/amm_trading_fee/ |
tequdev
added
the
needs japanese translation
|
this PR will fix #2283 |
amarantha-k
approved these changes
Jan 3, 2024
tequdev
added a commit
to tequdev/xrpl-dev-portal
that referenced
this pull request
Jan 12, 2024
mDuo13
added a commit
that referenced
this pull request
Jan 16, 2024
tequdev
removed
the
needs japanese translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discounted trading fee always being 0 was a leftover from the in-development version of the amendment. The version as released in 1.12.0 has a non-zero trading fee based on the AMM's current trading fee.