host: vegman: Add show host bifurcation command #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alatarum
reviewed
Jul 29, 2022
| # @sudo cmd_config_bifurcation_show admin,operator,user | ||
| # @doc cmd_config_bifurcation_show | ||
| # Show host bifurcation | ||
| function cmd_config_bifurcation_show { |
There was a problem hiding this comment.
Hey, what are you doing here? What is the idea of the change? I feel it is not what you expect.
There was a problem hiding this comment.
My task says to add host config bifurcation show command to the CLI using the host-pcie-cfg command that you (iirc) implemented.
AlexanderAmelkin
suggested changes
Aug 1, 2022
commands/host.vegman
Outdated
|
|
||
| # @sudo cmd_config_bifurcation_show admin,operator,user | ||
| # @doc cmd_config_bifurcation_show | ||
| # Show host bifurcation |
There was a problem hiding this comment.
Not exactly. It's "Show PCIe bifurcation requested by BMC from the host".
| # @doc cmd_config_bifurcation_show | ||
| # Show host bifurcation | ||
| function cmd_config_bifurcation_show { | ||
| exec_tool host-pcie-cfg "$@" |
There was a problem hiding this comment.
Please add a message before exec_tool saying something like:
Below are the PCIe bifurcation settings requested by the BMC.
The actual bifurcation may differ based on the UEFI Setup
settings as well as on training results:
Added the command to show host bifurcation. Signed-off-by: Kirill Pakhomov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the command to show host bifurcation.
Signed-off-by: Kirill Pakhomov [email protected]