Skip to content

host: vegman: Add show host bifurcation command #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

host: vegman: Add show host bifurcation command #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions commands/host.vegman
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,23 @@ function cmd_config_default {
config_default_${action} ${yes}
}

# @sudo cmd_config_bifurcation admin,operator,user
# @doc cmd_config_bifurcation
# Host bifurcation
function cmd_config_bifurcation {
subcommand "$@"
}

# @sudo cmd_config_bifurcation_show admin,operator,user
# @doc cmd_config_bifurcation_show
# Show PCIe bifurcation requested by BMC from the host
function cmd_config_bifurcation_show {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, what are you doing here? What is the idea of the change? I feel it is not what you expect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My task says to add host config bifurcation show command to the CLI using the host-pcie-cfg command that you (iirc) implemented.

printf "Below are the PCIe bifurcation settings requested by the BMC.
The actual bifurcation may differ based on the UEFI Setup
settings as well as on training results:\n\n"
exec_tool host-pcie-cfg "$@"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a message before exec_tool saying something like:

Below are the PCIe bifurcation settings requested by the BMC.
The actual bifurcation may differ based on the UEFI Setup
settings as well as on training results:

}

# @sudo cmd_nmi admin
# @restrict cmd_nmi admin
# @doc cmd_nmi
Expand Down