-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Handle dyndns subscribe/unsubscribe in web admin #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but i'm thinking we could also have an option to set / change the dyndns recovery password a-posteriori using the config panel ... Imho we should be tweaking config_domain.toml
in the core with the appropriate visible
condition etc, does that makes sense ? (Maybe it's sort of hard-coded in the webadmin here but I'm not knowledgeable enough in Vue to be 100% it is not 😅 )
The password change is already available in the config panel thanks to https://github.com/YunoHost/yunohost/pull/1715/files#diff-c7a5d00cafa16dd4d6f0f5e7f2606c604de3d8341b281c5f1f14cfa709eed304R548-R550 and the |
Oooh neat 👍 |
Solution
require YunoHost/yunohost#1715