Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Handle dyndns subscribe/unsubscribe in web admin #529

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Conversation

Axolotle
Copy link
Member

@Axolotle Axolotle commented Sep 25, 2023

Solution

  • add recovery password in domain form (postinstall + DomainAdd) for dyndns
  • add checkbox to unsubscribe the domain while removing it.

require YunoHost/yunohost#1715

Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i'm thinking we could also have an option to set / change the dyndns recovery password a-posteriori using the config panel ... Imho we should be tweaking config_domain.toml in the core with the appropriate visible condition etc, does that makes sense ? (Maybe it's sort of hard-coded in the webadmin here but I'm not knowledgeable enough in Vue to be 100% it is not 😅 )

app/src/views/domain/DomainInfo.vue Outdated Show resolved Hide resolved
@Axolotle
Copy link
Member Author

Axolotle commented Sep 27, 2023

LGTM but i'm thinking we could also have an option to set / change the dyndns recovery password a-posteriori using the config panel ... Imho we should be tweaking config_domain.toml in the core with the appropriate visible condition etc, does that makes sense ? (Maybe it's sort of hard-coded in the webadmin here but I'm not knowledgeable enough in Vue to be 100% it is not 😅 )

The password change is already available in the config panel thanks to https://github.com/YunoHost/yunohost/pull/1715/files#diff-c7a5d00cafa16dd4d6f0f5e7f2606c604de3d8341b281c5f1f14cfa709eed304R548-R550 and the apply part is https://github.com/YunoHost/yunohost/pull/1715/files#diff-24c783c1e108af4846094b6b66f6be63c3304e9f92e61cb9b20f99db409d4738R712-R719

@alexAubin
Copy link
Member

Oooh neat 👍

@alexAubin alexAubin merged commit c03fe36 into dev Sep 29, 2023
1 check passed
@alexAubin alexAubin deleted the dyndns branch November 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants