enh: Handle dyndns subscribe/unsubscribe in web admin #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not available
…e trying to unsubscribe
alexAubin
reviewed
Sep 27, 2023
alexAubin
reviewed
Sep 27, 2023
…ert/dyndns/setting cleanup before the regenconf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Adapt a bit the subscription for the web admin.
Most of the changes while adding a domain is about trying to unsubscribe the domain if it is not available and a recovery password is set, before trying to subscribe to it again.
PR Status
Needs moar tests.
We may have to change dynette's requests limiter value. One is allowed to subscribe/unsubscribe 5 times per hour only.
How to test
add a dyndns domain with a recovery password
check that a password is set in the domain's config panel
delete the domain without subscribing to it
try to readd the domain with the recovery password
add a dyndns domain without recovery password
set one with the config panel
delete the domain without subscribing to it
try to readd the domain with the recovery password