Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add achievement logos (1/2) #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

piedpiper358
Copy link

I finally found it)

@piedpiper358
Copy link
Author

I would like these changes to be merged as soon as possible so that I can already move on to the next step and add the SVGs themselves.

@sebastientromp
Copy link
Contributor

sebastientromp commented Sep 5, 2022

Sorry, I missed that one.
These are in fact automatically generated (like all localized files), so it should be modified in the generator (which is not in a public repo).

Before updating the generator I'd like to have the svg files already in the repo, as the file is updated outside of the app's release cycle.

@piedpiper358
Copy link
Author

You should have said this earlier. I wouldn't have spent so much time on it then : )
Okay, I'll upload files now.
Please note that in addition to changing sets icons, I also added icons for arena, mercenaries and books.

@sebastientromp
Copy link
Contributor

Yeah sorry about that, it was a bit difficult to keep track of everything while on vacation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants