feat: source sidekiq-batch from GitHub repository
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzlaura
approved these changes
Jul 21, 2024
|
This has addressed the heroku-24 build/release issue 🎉 |
|
Awesome! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Sidekiq v7 has been landed in the repository (breamware/sidekiq-batch#89 & breamware/sidekiq-batch#85), but not yet released - hopefully that'll happen soon, but in the meantime I'm switching us to pull from the repository because
gitat runtime which looks to be causing our deployment to fail becausesidekiq-batch.gemspectries to dogit ls-remote -zfor determining the files to include; we might still run into issues because we're technically still usinggit, but I'm hoping this moves our usage into the "build" phase wheregitshould still be available...