fix: address LUT issues on tests #811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Maree <[email protected]>
md0x
reviewed
Dec 19, 2024
| // Avoids invalid ALT index as ALT might not be active yet on the following tx. | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); | ||
| // Wait for slot to advance. LUTs only active after slot advance. | ||
| const initialSlot = await connection.getSlot(); |
There was a problem hiding this comment.
Nice finding!
Suggestion: Could we use something like this connection.onSlotChange to subscribe to slot changes? Not sure how reliable onSlotChange is though
There was a problem hiding this comment.
I tried this and this was better. not sure if onSlotChange was delayed or returned early but it did to result in the tests always working as expected, like this implementation does.
Reinis-FRP
reviewed
Dec 20, 2024
src/svm/transactionUtils.ts
Outdated
| await web3.sendAndConfirmTransaction(connection, new web3.Transaction().add(extendInstruction), [sender], { | ||
| skipPreflight: true, // Avoids recent slot mismatch in simulation. | ||
| }); | ||
| await web3.sendAndConfirmTransaction(connection, new web3.Transaction().add(extendInstruction), [sender]); |
There was a problem hiding this comment.
shall we also set this to "confirmed", otherwise might default to "max"
Signed-off-by: Chris Maree <[email protected]>
Reinis-FRP
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses an issue we were seeing with unit tests after an anchor update. Now, all tests work.
reason this was needed is as follows: