feat(svm): clean up fixed todos #815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <[email protected]>
md0x
commented
Dec 20, 2024
| @@ -84,7 +84,6 @@ pub struct FilledV3Relay { | |||
| pub relayer: Pubkey, | |||
| pub depositor: Pubkey, | |||
| pub recipient: Pubkey, | |||
| // TODO: update EVM implementation to use message_hash in all fill related events. | |||
md0x
commented
Dec 20, 2024
| @@ -88,7 +88,6 @@ pub fn invoke_handler<'info>( | |||
|
|
|||
| let instruction = Instruction { program_id: message.handler, accounts, data }; | |||
|
|
|||
| // TODO: consider if the message handler requires signed invocation. | |||
There was a problem hiding this comment.
Open question resolved: no need for the handler to authenticate the caller, as we don’t handle permissioned transactions in EVM (cc: @Reinis-FRP )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: