Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svm): clean up fixed todos #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(svm): clean up fixed todos #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion programs/svm-spoke/src/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ pub struct FilledV3Relay {
pub relayer: Pubkey,
pub depositor: Pubkey,
pub recipient: Pubkey,
// TODO: update EVM implementation to use message_hash in all fill related events.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here: #772

pub message_hash: [u8; 32],
pub relay_execution_info: V3RelayExecutionEventInfo,
}
Expand Down
1 change: 0 additions & 1 deletion programs/svm-spoke/src/utils/message_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ pub fn invoke_handler<'info>(

let instruction = Instruction { program_id: message.handler, accounts, data };

// TODO: consider if the message handler requires signed invocation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question resolved: no need for the handler to authenticate the caller, as we don’t handle permissioned transactions in EVM (cc: @Reinis-FRP )

invoke(&instruction, account_infos)?;

Ok(())
Expand Down
Loading