Fix test net tcp retry #1979
Merged
Fix test net tcp retry #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plajjan
force-pushed
the
fix-test-net-tcp-retry
branch
from
848caf8
to
7504ae4
Compare
Sometimes we want to know if we succeeded in listening, so changing the on_error() callback to on_listen() and the error message is now an optional, so if it is None, it means all went well!
We get some races since we start the client and server at the same time, but the server listener might fail if the port is already taken. We now avoid that race by checking if the listener starts up correctly and only then initiating the client. Also ignoring any possible received data from older clients (which really shouldn't be able to happen!). Overall, tests should be stable now.
plajjan
force-pushed
the
fix-test-net-tcp-retry
branch
from
7504ae4
to
bdd21b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.