Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test net tcp retry #1979

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix test net tcp retry #1979

merged 3 commits into from
Nov 8, 2024

Commits on Nov 8, 2024

  1. Correct on_receive callback arg

    @plajjan
    plajjan committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c220c94 View commit details
    Browse the repository at this point in the history

  2. Change on_listen callback to also signal success 

    Sometimes we want to know if we succeeded in listening, so changing the
on_error() callback to on_listen() and the error message is now an
optional, so if it is None, it means all went well!
    @plajjan
    plajjan committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8b11e2a View commit details
    Browse the repository at this point in the history

  3. Robustify TCP tests 

    We get some races since we start the client and server at the same time,
but the server listener might fail if the port is already taken. We now
avoid that race by checking if the listener starts up correctly and only
then initiating the client. Also ignoring any possible received data
from older clients (which really shouldn't be able to happen!).

Overall, tests should be stable now.
    @plajjan
    plajjan committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bdd21b7 View commit details
    Browse the repository at this point in the history