fix gocardless error handling #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
matt-fidd
changed the title
tcrasset
reviewed
Aug 22, 2024
MikesGlitch
reviewed
Aug 25, 2024
| handleGoCardlessError(response); | ||
| let response; | ||
| try { | ||
| response = client.deleteRequisition(requisitionId); |
There was a problem hiding this comment.
Nit: You can return this response directly rather than declaring "response" outside of the try.
I think the last return response; is unreachable due to handleGoCardlessError always throwing
Same with the others
There was a problem hiding this comment.
I think l prefer leaving it as-is makes any expandability in the future a little easier, and IMO makes the function slightly easier to read. They're tiny little functions but my go to quick check for return value when reading tends to be the bottom.
- Stuff happens
- Handle errors
- Default return case for success
As opposed to
- Stuff happens and returns if success
- Error
2 tasks
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
* fix gocardless error handling * release note * remove redundant tests * tcrasset feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #431
It looks like GoCardless error handling wasn't working at all as
handleGoCardlessErrorwas never reached when client.${method} threw an error.Cheking the GCL docs, there is no behaviour defined that would return a 200 response with an error status code so Axios should always throw an error.
This changes fixes that, and allows the basic rate limit error to be sent back to the client.