Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for showing and rendering the “Show unused payees” button #1335

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jul 13, 2023

  • The button will now be hidden by default so that users who don’t have any unused payees won’t have to think about it (since we merge by default, unused payees should be pretty rare)
  • The number of unused payees will be shown on the button to help understand how much cleanup needs to be done

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 278b921
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64b064d3401f55000788e288
😎 Deploy Preview https://deploy-preview-1335--actualbudget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
13 2.34 MB -> 2.34 MB (+6 B) +0.00%
Changeset
File Δ Size
src/components/payees/index.js 📈 +19 B (+0.18%) 10.4 KB -> 10.42 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.03 MB -> 1.03 MB (+6 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/457.chunk.js 387.21 KB 0%
static/media/Inter.var.woff2 317.25 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/media/bg.svg 116.73 KB 0%
static/js/reports.chunk.js 20.77 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 6.08 KB 0%
index.html 1.68 KB 0%
asset-manifest.json 1.47 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1016.62 KB 0%
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@j-f1 j-f1 mentioned this pull request Jul 13, 2023
Copy link
Contributor

@biohzrddd biohzrddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and functions as expected. It will also help out my dark theme.

LGTM

@j-f1 j-f1 merged commit 9d31120 into master Jul 17, 2023
@j-f1 j-f1 deleted the jed/unused-payees branch July 17, 2023 21:30
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 17, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants