[WIP] Dark theme #922
[WIP] Dark theme #922
Conversation
❌ Deploy Preview for actualbudget failed.
|
|
Linking to #618 |
|
👋 just checking in: are you planing to pick this up again? Any blockers or issues we could help with? |
biohzrddd
force-pushed
the
dark-theme
branch
2 times, most recently
from
d8135c6
to
400078d
Compare
| let borderColor = selected ? colors.b8 : colors.border; | ||
| let borderColor = selected | ||
| ? colors.tableBorderSelected | ||
| : colors.tableBorder; |
There was a problem hiding this comment.
This doesn’t appear to do anything? (the border color doesn’t change in either light or dark mode)
| /> | ||
| )} | ||
| </View> | ||
| {!buttonsDisabled ? ( |
There was a problem hiding this comment.
Why remove this button when there is no selection?
| @@ -91,7 +96,7 @@ function Header({ | |||
| }} | |||
| > | |||
| <CustomSelect | |||
| style={{ backgroundColor: 'white' }} | |||
| style={{ ...styles.smallText }} | |||
There was a problem hiding this comment.
nit:
| style={{ ...styles.smallText }} | |
| style={styles.smallText} |
(or, alternately, apply this to the CustomSelect by default to fix the font sizing issue)
| @@ -101,7 +106,7 @@ function Header({ | |||
| /> | |||
| <View>to</View> | |||
| <CustomSelect | |||
| style={{ backgroundColor: 'white' }} | |||
| style={{ ...styles.smallText }} | |||
There was a problem hiding this comment.
| style={{ ...styles.smallText }} | |
| style={styles.smallText} |
| <Text style={{ fontWeight: 600 }}>Upcoming dates</Text> | ||
| <Stack direction="column" spacing={1} style={{ marginTop: 10 }}> |
There was a problem hiding this comment.
IMO these should go back to having a secondary text color so that they stand out less.
| {state.isCustom && ( | ||
| <Text | ||
| style={{ | ||
| color: colors.b5, |
There was a problem hiding this comment.
Without this coloring, this doesn’t stand out as much anymore — can you make it a little more noticeable?
| }} | ||
| onClick={() => onSwitchTransactions('matched')} | ||
| > |
There was a problem hiding this comment.
Same here — why was this coloring removed?
| default: | ||
| <Text>These transactions match this schedule:</Text> | ||
| <View style={{ flex: 1 }} /> | ||
| <Text>Select transactions to link on save</Text> |
| transactions={state.transactions} | ||
| fields={['date', 'payee', 'amount']} | ||
| style={{ | ||
| border: '1px solid ' + colors.border, |
There was a problem hiding this comment.
now the table area is missing a border when empty. Also somehow the table always has zero height so you can’t see any transactions.
|
If you want me to help out with anything (merge conflicts, changes I’ve requested, etc) feel free to reach out! I don’t want you to burn out on this & also want to keep other PRs moving as possible. |
|
Help needed to push this to completion. |
|
Progress so far: |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
Ready to merge!
This is an overhaul of the way colors are used in Actual in order to add a dark theme. It also adds the possibility of future themes.
Please see the netlify preview here then give your opinion and rationale on any found issues either here on github or on our Discord feedback thread.
Dark
Light
