-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest SVGR version & re-generate all icons #1368
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Co-Authored-By: biohzrddd <[email protected]>
You’re just a little bit too fast :) |
Agree with the update to make all icons inherit color by default. However, and I might be in the minority here, the example you showed doesn't feel correct. The icon should be a static control and the drop-down arrow should remain black while the text changes. |
…et#1368) Co-authored-by: biohzrddd <[email protected]>
I re-ran it for #1367 and saw a bunch of changes, so I’m pulling them into a different PR.
This PR also changes the icon
color
property toinherit
, fixing a bunch of minor UI issues (pulled out of #922). For example:→