Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest SVGR version & re-generate all icons #1368

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jul 19, 2023

I re-ran it for #1367 and saw a bunch of changes, so I’m pulling them into a different PR.

This PR also changes the icon color property to inherit, fixing a bunch of minor UI issues (pulled out of #922). For example:
Screenshot_2023-07-19 16 05 33Screenshot_2023-07-19 16 05 59

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit ee4b746
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64b85ac93028df000897d9fc
😎 Deploy Preview https://deploy-preview-1368.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.06 MB -> 2.06 MB (-4.39 KB) -0.21%
Changeset
File Δ Size
package.json 📈 +98 B (+5.34%) 1.79 KB -> 1.89 KB
src/components/table.tsx 📉 -8 B (-0.03%) 22.48 KB -> 22.48 KB
src/components/budget/MobileBudgetTable.js 📉 -16 B (-0.07%) 22.18 KB -> 22.16 KB
src/components/payees/index.js 📉 -16 B (-0.15%) 10.6 KB -> 10.59 KB
src/components/FinancesApp.tsx 📉 -16 B (-0.21%) 7.61 KB -> 7.6 KB
src/components/transactions/TransactionsTable.js 📉 -85 B (-0.21%) 38.74 KB -> 38.66 KB
src/components/autocomplete/PayeeAutocomplete.js 📉 -16 B (-0.23%) 6.76 KB -> 6.75 KB
src/components/schedules/SchedulesTable.js 📉 -16 B (-0.24%) 6.49 KB -> 6.48 KB
src/components/modals/GoCardlessExternalMsg.js 📉 -16 B (-0.24%) 6.48 KB -> 6.46 KB
src/components/filters/FiltersMenu.js 📉 -32 B (-0.33%) 9.54 KB -> 9.51 KB
src/components/alerts.tsx 📉 -6 B (-0.41%) 1.45 KB -> 1.44 KB
src/components/SidebarWithData.js 📉 -16 B (-0.43%) 3.63 KB -> 3.61 KB
src/components/budget/BalanceWithCarryover.tsx 📉 -5 B (-0.47%) 1.03 KB -> 1.03 KB
src/components/accounts/MobileAccountDetails.js 📉 -16 B (-0.50%) 3.14 KB -> 3.12 KB
src/components/Titlebar.js 📉 -45 B (-0.55%) 8.06 KB -> 8.02 KB
src/components/sidebar.js 📉 -64 B (-0.57%) 10.97 KB -> 10.91 KB
src/components/budget/MonthCountSelector.js 📉 -6 B (-0.58%) 1.01 KB -> 1 KB
src/components/autocomplete/CategorySelect.tsx 📉 -16 B (-0.60%) 2.63 KB -> 2.61 KB
src/components/accounts/AccountSyncCheck.js 📉 -21 B (-0.65%) 3.15 KB -> 3.13 KB
src/components/manager/BudgetList.js 📉 -44 B (-0.71%) 6.07 KB -> 6.03 KB
src/components/schedules/StatusBadge.js 📉 -16 B (-0.84%) 1.86 KB -> 1.85 KB
src/components/NotesButton.tsx 📉 -21 B (-0.86%) 2.39 KB -> 2.37 KB
src/components/common/Button.tsx 📉 -26 B (-1.20%) 2.12 KB -> 2.1 KB
src/components/accounts/Header.js 📉 -109 B (-1.20%) 8.88 KB -> 8.77 KB
src/components/common/MenuButton.tsx 📉 -16 B (-3.74%) 428 B -> 412 B
src/components/AnimatedRefresh.js 📉 -26 B (-4.88%) 533 B -> 507 B
src/icons/v2/Eye.js 📉 -1.06 KB (-40.19%) 2.63 KB -> 1.58 KB
src/icons/v2/EyeSlashed.js 📉 -2.67 KB (-51.66%) 5.17 KB -> 2.5 KB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/main.js 839.99 KB -> 835.91 KB (-4.08 KB) -0.49%
static/js/wide-components.chunk.js 155.94 KB -> 155.69 KB (-262 B) -0.16%
static/js/reports.chunk.js 31.89 KB -> 31.86 KB (-30 B) -0.09%
static/js/narrow-components.chunk.js 32.2 KB -> 32.17 KB (-28 B) -0.08%

Unchanged

Asset File Size % Changed
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/media/bg.svg 116.73 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.01 KB 0%
index.html 1.68 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.96 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1008 KB 0%
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@j-f1 j-f1 marked this pull request as draft July 19, 2023 19:49
@j-f1 j-f1 marked this pull request as ready for review July 19, 2023 21:06
@j-f1
Copy link
Contributor Author

j-f1 commented Jul 19, 2023

You’re just a little bit too fast :)

@j-f1 j-f1 merged commit 5cd6b6b into master Jul 19, 2023
15 checks passed
@j-f1 j-f1 deleted the jed/svgr branch July 19, 2023 22:57
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jul 19, 2023
@biohzrddd
Copy link
Contributor

I re-ran it for #1367 and saw a bunch of changes, so I’m pulling them into a different PR.

This PR also changes the icon color property to inherit, fixing a bunch of minor UI issues (pulled out of #922). For example: Screenshot_2023-07-19 16 05 33Screenshot_2023-07-19 16 05 59

Agree with the update to make all icons inherit color by default. However, and I might be in the minority here, the example you showed doesn't feel correct. The icon should be a static control and the drop-down arrow should remain black while the text changes.

This was referenced Jul 21, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants