Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (common) migrating to specific common component import paths #1418

Merged
merged 5 commits into from
Jul 30, 2023

Conversation

MatissJanis
Copy link
Member

Just moving away from the barrel common export to a bit more specific imports.

Part 1 of the migration (other imports to follow in other PRs).

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0f81eea
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64c580091436b70008e7ce97
😎 Deploy Preview https://deploy-preview-1418.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB -> 2.08 MB (+1.37 KB) +0.06%
Changeset
File Δ Size
src/components/common/Stack.tsx 🆕 +1.35 KB 0 B -> 1.35 KB
src/components/budget/rollover/HoldTooltip.tsx 📈 +137 B (+8.61%) 1.55 KB -> 1.69 KB
src/components/modals/CreateLocalAccount.js 📈 +249 B (+7.74%) 3.14 KB -> 3.38 KB
src/components/LoggedInUser.js 📈 +112 B (+5.37%) 2.04 KB -> 2.15 KB
src/components/budget/rollover/TransferTooltip.tsx 📈 +137 B (+5.32%) 2.52 KB -> 2.65 KB
src/components/util/AmountInput.js 📈 +75 B (+4.31%) 1.7 KB -> 1.77 KB
src/components/schedules/LinkSchedule.js 📈 +63 B (+4.18%) 1.47 KB -> 1.53 KB
src/components/SidebarWithData.js 📈 +148 B (+4.07%) 3.55 KB -> 3.69 KB
src/components/NotesButton.tsx 📈 +85 B (+3.50%) 2.37 KB -> 2.46 KB
src/components/accounts/MobileAccountDetails.js 📈 +104 B (+3.25%) 3.12 KB -> 3.22 KB
src/components/schedules/index.js 📈 +65 B (+3.21%) 1.97 KB -> 2.04 KB
src/components/accounts/Header.js 📈 +266 B (+2.95%) 8.8 KB -> 9.06 KB
src/components/budget/report/BudgetSummary.tsx 📈 +236 B (+2.82%) 8.16 KB -> 8.39 KB
src/components/accounts/AccountSyncCheck.js 📈 +83 B (+2.60%) 3.11 KB -> 3.19 KB
src/components/modals/GoCardlessExternalMsg.js 📈 +174 B (+2.60%) 6.53 KB -> 6.7 KB
src/components/filters/SavedFilters.js 📈 +155 B (+2.60%) 5.83 KB -> 5.98 KB
src/components/budget/rollover/BudgetSummary.tsx 📈 +205 B (+2.44%) 8.2 KB -> 8.4 KB
src/components/reports/CashFlow.js 📈 +97 B (+2.33%) 4.06 KB -> 4.16 KB
src/components/select/RecurringSchedulePicker.js 📈 +151 B (+1.92%) 7.68 KB -> 7.83 KB
src/components/schedules/SchedulesTable.js 📈 +116 B (+1.75%) 6.48 KB -> 6.59 KB
src/components/accounts/MobileAccounts.js 📈 +98 B (+1.74%) 5.5 KB -> 5.6 KB
src/components/budget/report/components.tsx 📈 +128 B (+1.70%) 7.34 KB -> 7.47 KB
src/components/filters/FiltersMenu.js 📈 +175 B (+1.69%) 10.13 KB -> 10.3 KB
src/components/budget/rollover/rollover-components.tsx 📈 +167 B (+1.66%) 9.83 KB -> 10 KB
src/components/payees/index.js 📈 +145 B (+1.33%) 10.62 KB -> 10.76 KB
src/components/sidebar.js 📈 +129 B (+1.15%) 10.91 KB -> 11.04 KB
src/components/modals/EditRule.js 📈 +176 B (+0.97%) 17.69 KB -> 17.87 KB
src/components/accounts/Reconcile.js 📈 +25 B (+0.83%) 2.93 KB -> 2.96 KB
src/components/select/DateSelect.js 📈 +59 B (+0.76%) 7.63 KB -> 7.68 KB
src/components/transactions/MobileTransaction.js 📈 +68 B (+0.74%) 8.96 KB -> 9.02 KB
src/components/autocomplete/Autocomplete.tsx 📈 +89 B (+0.68%) 12.69 KB -> 12.78 KB
src/components/common/MenuTooltip.tsx 📈 +2 B (+0.67%) 298 B -> 300 B
src/components/table.tsx 📈 +140 B (+0.61%) 22.48 KB -> 22.62 KB
src/components/manager/BudgetList.js 📈 +25 B (+0.40%) 6.05 KB -> 6.08 KB
src/components/reports/graphs/net-worth-spreadsheet.tsx 📈 +12 B (+0.38%) 3.09 KB -> 3.11 KB
src/components/Titlebar.js 📈 +24 B (+0.30%) 7.86 KB -> 7.88 KB
src/components/reports/graphs/cash-flow-spreadsheet.tsx 📈 +12 B (+0.27%) 4.37 KB -> 4.39 KB
src/components/transactions/TransactionsTable.js 📈 +88 B (+0.22%) 38.9 KB -> 38.99 KB
src/components/budget/misc.js 📈 +25 B (+0.10%) 23.85 KB -> 23.87 KB
src/components/tooltips.js 📉 -1.31 KB (-14.44%) 9.1 KB -> 7.79 KB
src/components/common.tsx 📉 -559 B (-24.79%) 2.2 KB -> 1.66 KB
src/components/Stack.tsx 🔥 -1.36 KB (-100%) 1.36 KB -> 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide-components.chunk.js 159.3 KB -> 160.5 KB (+1.2 KB) +0.75%
static/js/reports.chunk.js 32.27 KB -> 32.6 KB (+335 B) +1.01%
static/js/narrow-components.chunk.js 31.94 KB -> 32.13 KB (+193 B) +0.59%

Smaller

Asset File Size % Changed
static/js/main.js 848.84 KB -> 848.5 KB (-346 B) -0.04%

Unchanged

Asset File Size % Changed
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1011.11 KB 0%
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@MatissJanis MatissJanis merged commit 60e5f1a into master Jul 30, 2023
15 checks passed
@MatissJanis MatissJanis deleted the matiss/migrate-paths branch July 30, 2023 12:22
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 30, 2023
MatissJanis added a commit that referenced this pull request Jul 30, 2023
…1419)

Part 2 of the path migration. No functional changes.

Part 1: #1418

---------

Co-authored-by: Jed Fox <[email protected]>
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…albudget#1418)

Just moving away from the barrel `common` export to a bit more specific
imports.

Part 1 of the migration (other imports to follow in other PRs).
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…ctualbudget#1419)

Part 2 of the path migration. No functional changes.

Part 1: actualbudget#1418

---------

Co-authored-by: Jed Fox <[email protected]>
my2 added a commit to my2/actual that referenced this pull request Aug 13, 2024
…#1419)

Part 2 of the path migration. No functional changes.

Part 1: actualbudget/actual#1418

---------

Co-authored-by: Jed Fox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants