Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Goals: Monthly schedule can cause error #1478

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

shall0pass
Copy link
Contributor

The 'interval' value from the schedules is not set if the schedule is monthly. This change will check for a valid number for the interval value and if it does not exist will default to 1 (monthly).

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6640c38
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64d0266f559ebb0008c3a517
😎 Deploy Preview https://deploy-preview-1478.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 851.69 kB 0%
static/js/457.chunk.js 388.22 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/wide-components.chunk.js 159.29 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 33.23 kB 0%
static/js/narrow-components.chunk.js 32.06 kB 0%
static/js/281.chunk.js 28.55 kB 0%
static/js/876.chunk.js 26.2 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB → 1.97 MB (+19 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/server/budget/goaltemplates.ts 📈 +36 B (+0.13%) 26.25 kB → 26.29 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1012.1 kB → 1012.12 kB (+19 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 kB 0%

@@ -649,7 +649,9 @@ async function applyCategoryTemplate(
dateConditions,
monthUtils._parse(current_month),
);
let target_interval = dateConditions.value.interval;
let target_interval = dateConditions.value.interval
Copy link
Contributor Author

@shall0pass shall0pass Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_interval previously was set to null if the schedule was exactly 1 month.

@MatissJanis MatissJanis added this to the v23.8.1 milestone Aug 7, 2023
@shall0pass shall0pass merged commit 40d9414 into actualbudget:master Aug 7, 2023
15 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Aug 7, 2023
@shall0pass shall0pass deleted the schedule_intervalValue branch August 18, 2023 16:30
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
The 'interval' value from the schedules is not set if the schedule is
monthly. This change will check for a valid number for the interval
value and if it does not exist will default to 1 (monthly).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants