Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Goals: Monthly schedule can cause error #1478

Merged
merged 2 commits into from
Aug 7, 2023
Merged

[Bug] Goals: Monthly schedule can cause error #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab647db
check for a real value
shall0pass Aug 6, 2023
6640c38
release note
shall0pass Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/loot-core/src/server/budget/goaltemplates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,9 @@ async function applyCategoryTemplate(
dateConditions,
monthUtils._parse(current_month),
);
let target_interval = dateConditions.value.interval;
let target_interval = dateConditions.value.interval
Copy link
Contributor Author

@shall0pass shall0pass Aug 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_interval previously was set to null if the schedule was exactly 1 month.

? dateConditions.value.interval
: 1;
let target_frequency = dateConditions.value.frequency;
let isRepeating =
Object(dateConditions.value) === dateConditions.value &&
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/1478.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [shall0pass]
---

Goals: Fix error that can occur with monthly schedules