fix: Change to new-style-jax-rng-keys. #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All calls to jax.random.PRNGKey have been changed to jax.random.key. When passing keys to non-jax methods (such as the ones in scikit-learn), we use jax.key_data to recover the underlying raw key information.
Lookatator
added
enhancement
1 task
|
Hi @miltonllera, thanks a lot for those changes! Because of the unsuccessful checks, I copied your commits to a branch in our repository, and solved all issues in PR #195 I will close this PR, the new one should be merged very soon into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All calls to
jax.random.PRNGKeyhave been changed tojax.random.key. When passing keys to non-jax methods (such as the ones in scikit-learn), we firstjax.key_datato recover the underlying raw key information before making the call.Related issues: https://jax.readthedocs.io/en/latest/jep/9263-typed-keys.html