Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change to new-style-jax-rng-keys. #195

Merged
merged 5 commits into from
Sep 21, 2024

Conversation

Lookatator
Copy link
Member

This PR is an internal copy of #184:

All calls to jax.random.PRNGKey have been changed to jax.random.key. When passing keys to non-jax methods (such as the ones in scikit-learn), we first jax.key_data to recover the underlying raw key information before making the call.
Related issues: https://jax.readthedocs.io/en/latest/jep/9263-typed-keys.html

with the following additional changes:

  • remaining jax.random.PRNGKey have been changed to jax.random.key.
  • all checks now pass

Checks

  • a clear description of the PR has been added

miltonllera and others added 3 commits May 21, 2024 17:58
All calls to jax.random.PRNGKey have been changed to jax.random.key.
When passing keys to non-jax methods (such as the ones in scikit-learn),
we use jax.key_data to recover the underlying raw key information.
@Lookatator Lookatator added the code update Updating to last library versions label Sep 13, 2024
@Lookatator Lookatator self-assigned this Sep 13, 2024
@Lookatator Lookatator added this to the v0.5.0 milestone Sep 20, 2024
@Lookatator Lookatator merged commit 6656f5e into develop Sep 21, 2024
5 checks passed
@Lookatator Lookatator deleted the miltonllera-new-style-jax-rng-keys branch September 21, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code update Updating to last library versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants